hooman-mirghasemi/Laravel-iran-sms

View on GitHub

Showing 6 of 6 total issues

Method getErrors has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getErrors(): array
    {
        $errors = [];
        $errors[1]['title'] = 'INVALID_RECIPIENT_NUMBER';
        $errors[1]['desc'] = 'the string you presented as recipient numbers are not valid phone numbers, please check them again';
Severity: Major
Found in src/Drivers/Magfa.php - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    <?php
    
    namespace HoomanMirghasemi\Sms\Channels;
    
    use Exception;
    Severity: Major
    Found in src/Channels/VoiceCallChannel.php and 1 other location - About 1 hr to fix
    src/Channels/SmsChannel.php on lines 1..44

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    <?php
    
    namespace HoomanMirghasemi\Sms\Channels;
    
    use Exception;
    Severity: Major
    Found in src/Channels/SmsChannel.php and 1 other location - About 1 hr to fix
    src/Channels/VoiceCallChannel.php on lines 1..44

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method send has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function send(): bool
        {
            try {
                if ($this->message->usesTemplate()) {
                    $template = $this->message->getTemplate();
    Severity: Minor
    Found in src/Drivers/Kavenegar.php - About 1 hr to fix

      Method register has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function register(): void
          {
              $this->mergeConfigFiles();
      
              $this->app->register(RouteServiceProvider::class);
      Severity: Minor
      Found in src/Providers/SmsProvider.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                    return new Avanak($config);
        Severity: Major
        Found in src/Providers/SmsProvider.php - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language