Sign upLogin

hopsoft/ellington

View on GitHub
Star

Showing 7 of 7 total issues

Method graph_route has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

    def graph_route(passenger=nil)
      g = Node.new(nil, GraphViz.new("GraphRoute"))
      set_graph_defaults g.viz
      g.viz[:label] = "#{class_label(route)} Lines"
      g.viz[:ranksep] = 0.8
Severity: Minor
Found in lib/ellington/visualizer.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method graph_route has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def graph_route(passenger=nil)
      g = Node.new(nil, GraphViz.new("GraphRoute"))
      set_graph_defaults g.viz
      g.viz[:label] = "#{class_label(route)} Lines"
      g.viz[:ranksep] = 0.8
Severity: Major
Found in lib/ellington/visualizer.rb - About 2 hrs to fix

    Method graph_route_basic has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def graph_route_basic(passenger=nil)
      g = Node.new(nil, GraphViz.new("GraphRouteBasic"))
      set_graph_defaults g.viz
      g.viz[:ranksep] = 1
      g.viz[:label] = "#{class_label(route)} Route - basic"
    Severity: Major
    Found in lib/ellington/visualizer.rb - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      module Ellington
  class StationList < SimpleDelegator
    attr_reader :line_class

    def initialize(line_class)
      Severity: Minor
      Found in lib/ellington/station_list.rb and 1 other location - About 50 mins to fix
      lib/ellington/line_list.rb on lines 3..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      module Ellington
  class LineList < SimpleDelegator
    attr_reader :route_class

    def initialize(route_class)
      Severity: Minor
      Found in lib/ellington/line_list.rb and 1 other location - About 50 mins to fix
      lib/ellington/station_list.rb on lines 3..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def route_completed_message
      message = []
      message << "[ROUTE COMPLETED]"
      message << "[#{route.state(passenger)}]"
      message << "[#{route.name}]"
      Severity: Minor
      Found in lib/ellington/route_info.rb and 1 other location - About 20 mins to fix
      lib/ellington/line_info.rb on lines 26..32

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 28.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def line_completed_message
      message = []
      message << "[LINE COMPLETED]"
      message << "[#{line.state(passenger)}]"
      message << "[#{line.name}]"
      Severity: Minor
      Found in lib/ellington/line_info.rb and 1 other location - About 20 mins to fix
      lib/ellington/route_info.rb on lines 13..19

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 28.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language