Sign upLogin

hopsoft/field_mapper

View on GitHub
Star
lib/field_mapper/standard/converter.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method get_raw_custom_value has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

      def get_raw_custom_value(custom_field, raw_standard_value, custom_instance)
        strategy = custom_field.flip_strategy(:standard_to_custom)
        custom_flipper = custom_field.custom_flipper?(:standard_to_custom)

        if !custom_flipper
Severity: Minor
Found in lib/field_mapper/standard/converter.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

            return raw_standard_value.map do |single_raw_standard_value|
              find_raw_custom_value(custom_field, single_raw_standard_value)
            end
Severity: Major
Found in lib/field_mapper/standard/converter.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return find_raw_custom_value(custom_field, raw_standard_value)
    Severity: Major
    Found in lib/field_mapper/standard/converter.rb - About 30 mins to fix

      Method find_raw_custom_value has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def find_raw_custom_value(custom_field, raw_standard_value)
        return raw_standard_value unless custom_field.has_values?

        if !custom_field.standard_field.has_values?
          custom_value = custom_field.find_value(raw_standard_value)
      Severity: Minor
      Found in lib/field_mapper/standard/converter.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status