hopsoft/universalid

View on GitHub
lib/universalid/extensions/active_record/base_unpacker.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method assign_descendants has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

      def assign_descendants(record, attributes)
        descendants = attributes[UniversalID::Extensions::ActiveRecordBasePacker::DESCENDANTS_KEY] || {}
        descendants.each do |name, list|
          next unless record.respond_to?(name) && record.respond_to?(:"#{name}=")

Severity: Minor
Found in lib/universalid/extensions/active_record/base_unpacker.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_instance has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def create_instance(class_name, attributes)
        klass = Object.const_get(class_name) if Object.const_defined?(class_name)
        return nil unless klass

        record = if attributes[klass.primary_key]
Severity: Minor
Found in lib/universalid/extensions/active_record/base_unpacker.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status