horizoncd/horizon

View on GitHub
core/controller/badge/controller.go

Summary

Maintainability
A
1 hr
Test Coverage
D
66%

Showing 2 of 2 total issues

Method controller.UpdateBadgeByName has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

func (c *controller) UpdateBadgeByName(ctx context.Context, resourceType string,
resourceID uint, name string, badge *Update) (*Badge, error) {
Severity: Minor
Found in core/controller/badge/controller.go - About 35 mins to fix

    Method controller.CreateBadge has 5 return statements (exceeds 4 allowed).
    Open

    func (c *controller) CreateBadge(ctx context.Context, resourceType string,
    resourceID uint, badge *Create) (*Badge, error) {
    if err := c.checkResource(ctx, resourceType, resourceID); err != nil {
    return nil, err
    }
    Severity: Major
    Found in core/controller/badge/controller.go - About 35 mins to fix
      Category
      Status