horizoncd/horizon

View on GitHub
core/controller/member/models.go

Summary

Maintainability
B
5 hrs
Test Coverage
D
61%

Showing 3 of 3 total issues

Method converter.ConvertMembers has 79 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *converter) ConvertMembers(ctx context.Context, members []models.Member) ([]Member, error) {
var userIDs []uint
 
for _, member := range members {
if member.MemberType != models.MemberUser {
Severity: Major
Found in core/controller/member/models.go - About 2 hrs to fix

    Method converter.ConvertMembers has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
    Open

    func (c *converter) ConvertMembers(ctx context.Context, members []models.Member) ([]Member, error) {
    var userIDs []uint
     
    for _, member := range members {
    if member.MemberType != models.MemberUser {
    Severity: Minor
    Found in core/controller/member/models.go - About 1 hr to fix

    Method converter.ConvertMembers has 9 return statements (exceeds 4 allowed).
    Open

    func (c *converter) ConvertMembers(ctx context.Context, members []models.Member) ([]Member, error) {
    var userIDs []uint
     
    for _, member := range members {
    if member.MemberType != models.MemberUser {
    Severity: Major
    Found in core/controller/member/models.go - About 55 mins to fix
      Category
      Status