horizoncd/horizon

View on GitHub

Showing 440 of 677 total issues

Method API.BuildDeploy has 6 return statements (exceeds 4 allowed).
Open

func (a *API) BuildDeploy(c *gin.Context) {
op := "cluster: build deploy"
var request *cluster.BuildDeployRequest
if err := c.ShouldBindJSON(&request); err != nil {
response.AbortWithRequestError(c, common.InvalidRequestBody,
Severity: Major
Found in core/http/api/v2/cluster/apis_operation.go - About 40 mins to fix

    Method controller.GetApplication has 6 return statements (exceeds 4 allowed).
    Open

    func (c *controller) GetApplication(ctx context.Context, id uint) (_ *GetApplicationResponse, err error) {
    const op = "application controller: get application"
    defer wlog.Start(ctx, op).StopPrint()
     
    // 1. get application in db
    Severity: Major
    Found in core/controller/application/controller.go - About 40 mins to fix

      Method controller.UpdateByID has 6 return statements (exceeds 4 allowed).
      Open

      func (c *controller) UpdateByID(ctx context.Context,
      id uint, u *UpdateUserRequest) (*User, error) {
      currentUser, err := common.UserFromContext(ctx)
      if err != nil {
      return nil, err
      Severity: Major
      Found in core/controller/user/controller.go - About 40 mins to fix

        Method API.LoginCallback has 6 return statements (exceeds 4 allowed).
        Open

        func (a *API) LoginCallback(c *gin.Context) {
        code := c.Query(_oidcCode)
        state := c.Query(_oidcState)
        redirect := c.Query(_redirectURL)
        if code == "" || state == "" {
        Severity: Major
        Found in core/http/api/v2/idp/apis.go - About 40 mins to fix

          Method API.Create has 6 return statements (exceeds 4 allowed).
          Open

          func (a *API) Create(c *gin.Context) {
          const op = "application: create"
          groupIDStr := c.Param(common.ParamGroupID)
          groupID, err := strconv.ParseUint(groupIDStr, 10, 0)
          if err != nil {
          Severity: Major
          Found in core/http/api/v2/application/apis.go - About 40 mins to fix

            Function getScope has 6 return statements (exceeds 4 allowed).
            Open

            func getScope(c *gin.Context, mgr *managerparam.Manager, resourceType,
            resourceName string) (string, error) {
            var (
            resourceID uint
            cluster *clustermodels.Cluster
            Severity: Major
            Found in core/middleware/scope/scope.go - About 40 mins to fix

              Method API.List has 6 return statements (exceeds 4 allowed).
              Open

              func (a *API) List(c *gin.Context) {
              const op = "application: list application"
               
              keywords := make(map[string]interface{})
               
               
              Severity: Major
              Found in core/http/api/v2/application/apis.go - About 40 mins to fix

                Method service.CreateEventIgnoreError has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                func (s *service) CreateEventIgnoreError(ctx context.Context, resourceType string,
                resourceID uint, eventType string, extra *string) []*models.Event {
                Severity: Minor
                Found in pkg/event/service/service.go - About 35 mins to fix

                  Function Run has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  func Run(ctx context.Context, jobConfig *autofree.Config, userMgr usermanager.Manager,
                  clusterCtr clusterctl.Controller, prCtr prctl.Controller) {
                  Severity: Minor
                  Found in pkg/jobs/autofree/autofree.go - About 35 mins to fix

                    Method dao.List has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    func (d *dao) List(ctx context.Context, query *q.Query, userID uint,
                    withRegion bool, appIDs ...uint) (int, []*models.ClusterWithRegion, error) {
                    Severity: Minor
                    Found in pkg/cluster/dao/dao.go - About 35 mins to fix

                      Function NewCD has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      func NewCD(informerFactories *regioninformers.RegionInformers, clusterGitRepo gitrepo.ClusterGitRepo,
                      argoCDMapper argocdconf.Mapper, regionArgoCDMapper argocdconf.RegionMapper, targetRevision string) CD {
                      Severity: Minor
                      Found in pkg/cd/cd.go - About 35 mins to fix

                        Method manager.CreateLink has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        func (m *manager) CreateLink(ctx context.Context, uid uint,
                        idpID uint, claims *utils.Claims, deletable bool) (*models.UserLink, error) {
                        Severity: Minor
                        Found in pkg/userlink/manager/manager.go - About 35 mins to fix

                          Method helper.WriteFiles has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                          func (h *helper) WriteFiles(ctx context.Context, pid interface{}, branch, commitMsg string,
                          startBranch *string, actions []CommitAction) (_ *gitlab.Commit, err error) {
                          Severity: Minor
                          Found in lib/gitlab/gitlab.go - About 35 mins to fix

                            Function isClusterActuallyHealthy has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            func isClusterActuallyHealthy(ctx context.Context, clusterState *cd.ClusterState, image string,
                            restartTime time.Time, replicas int) bool {
                            Severity: Minor
                            Found in core/controller/cluster/controller_status.go - About 35 mins to fix

                              Method manager.UpdateByName has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                              func (m *manager) UpdateByName(ctx context.Context, resourceType string,
                              resourceID uint, name string, badge *models.Badge) (*models.Badge, error) {
                              Severity: Minor
                              Found in pkg/badge/manager/manager.go - About 35 mins to fix

                                Method manager.Get has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                func (m *manager) Get(ctx context.Context, resourceType models.ResourceType,
                                resourceID uint, memberType models.MemberType, memberInfo uint) (*models.Member, error) {
                                Severity: Minor
                                Found in pkg/member/manager/manager.go - About 35 mins to fix

                                  Method controller.CreateCluster has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                  func (c *controller) CreateCluster(ctx context.Context, applicationID uint, environment,
                                  region string, r *CreateClusterRequest, mergePatch bool) (_ *GetClusterResponse, err error) {
                                  Severity: Minor
                                  Found in core/controller/cluster/controller_basic.go - About 35 mins to fix

                                    Method service.getMember has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                    func (s *service) getMember(ctx context.Context, resourceType string, resourceID uint,
                                    memberType models.MemberType, memberInfo uint) (*models.Member, error) {
                                    Severity: Minor
                                    Found in pkg/member/service/service.go - About 35 mins to fix

                                      Method dao.Get has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                      func (d *dao) Get(ctx context.Context, resourceType models.ResourceType, resourceID uint,
                                      memberType models.MemberType, memberInfo uint) (*models.Member, error) {
                                      Severity: Minor
                                      Found in pkg/member/dao/dao.go - About 35 mins to fix

                                        Method helper.GetCreatedGroup has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                        Open

                                        func (h *helper) GetCreatedGroup(ctx context.Context, parentID int,
                                        parentFullPath string, name string, visibility string) (*gitlab.Group, error) {
                                        Severity: Minor
                                        Found in lib/gitlab/gitlab.go - About 35 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language