Sign upLogin

horizoncd/horizon

View on GitHub
Star

Showing 440 of 677 total issues

Method manager.Delete has 5 return statements (exceeds 4 allowed).
Open

func (m manager) Delete(ctx context.Context, id uint) (int64, error) {
    count, err := m.groupDAO.CountByParentID(ctx, id)
    if err != nil {
        return 0, err
    }
Severity: Major
Found in pkg/group/manager/manager.go - About 35 mins to fix

    Method Helper.GetTagArchive has 5 return statements (exceeds 4 allowed).
    Open

    func (h Helper) GetTagArchive(ctx context.Context, gitURL, tagName string) (*git.Tag, error) {
        pattern := regexp.MustCompile(`^(?:https://|git@)github.com[:/]([^/]+)/([^/]+?)(?:\.git)?$`)
        matches := pattern.FindAllStringSubmatch(gitURL, -1)
        if len(matches) == 0 || len(matches[0]) < 3 {
            return nil, perror.Wrapf(herrors.ErrParamInvalid, "git url is incorrect: git url = %s", gitURL)
    Severity: Major
    Found in pkg/git/github/github.go - About 35 mins to fix

      Method controller.UpdateTemplate has 5 return statements (exceeds 4 allowed).
      Open

      func (c *controller) UpdateTemplate(ctx context.Context, templateID uint, request UpdateTemplateRequest) error {
          const op = "template controller: updateTemplate"
          defer wlog.Start(ctx, op).StopPrint()
       
          template, err := c.templateMgr.GetByID(ctx, templateID)
      Severity: Major
      Found in core/controller/template/controller.go - About 35 mins to fix

        Method controller.GetClusterByName has 5 return statements (exceeds 4 allowed).
        Open

        func (c *controller) GetClusterByName(ctx context.Context,
            clusterName string) (_ *GetClusterByNameResponse, err error) {
            const op = "cluster controller: get cluster by name"
            wlog.Start(ctx, op).StopPrint()
         
         
        Severity: Major
        Found in core/controller/cluster/controller_basic.go - About 35 mins to fix

          Method controller.retrieveClaimsAndUser has 5 return statements (exceeds 4 allowed).
          Open

          func (c *controller) retrieveClaimsAndUser(ctx context.Context) (*tokenservice.Claims, *usermodel.User, error) {
              jwtTokenString, err := common.JWTTokenStringFromContext(ctx)
              if err != nil {
                  return nil, nil, err
              }
          Severity: Major
          Found in core/controller/cluster/controller_internal_v2.go - About 35 mins to fix

            Method dao.Create has 5 return statements (exceeds 4 allowed).
            Open

            func (d dao) Create(ctx context.Context, results *tekton.PipelineResults, data *global.HorizonMetaData) error {
                prMetadata := results.Metadata
                prResult := results.PrResult
                trResults, stepResults := results.TrResults, results.StepResults
             
             
            Severity: Major
            Found in pkg/pr/pipeline/dao/dao.go - About 35 mins to fix

              Method RegionList.Less has 5 return statements (exceeds 4 allowed).
              Open

              func (r RegionList) Less(i, j int) bool {
                  const pre = "pre"
                  const online = "online"
                  if r[i].Environment == online {
                      return false
              Severity: Major
              Found in core/controller/applicationregion/models.go - About 35 mins to fix

                Method controller.ListTemplateByGroupID has 5 return statements (exceeds 4 allowed).
                Open

                func (c *controller) ListTemplateByGroupID(ctx context.Context, groupID uint, withoutCI bool) (Templates, error) {
                    const op = "template controller: listTemplateByGroupID"
                    defer wlog.Start(ctx, op).StopPrint()
                 
                    if !c.groupMgr.GroupExist(ctx, groupID) {
                Severity: Major
                Found in core/controller/template/controller.go - About 35 mins to fix

                  Method controller.GetRelease has 5 return statements (exceeds 4 allowed).
                  Open

                  func (c *controller) GetRelease(ctx context.Context, releaseID uint) (*Release, error) {
                      const op = "template controller: getRelease"
                      defer wlog.Start(ctx, op).StopPrint()
                   
                      release, err := c.templateReleaseMgr.GetByID(ctx, releaseID)
                  Severity: Major
                  Found in core/controller/template/controller.go - About 35 mins to fix

                    Method controller.DeleteRelease has 5 return statements (exceeds 4 allowed).
                    Open

                    func (c *controller) DeleteRelease(ctx context.Context, releaseID uint) error {
                        const op = "template controller: deleteRelease"
                        defer wlog.Start(ctx, op).StopPrint()
                     
                        ctx = context.WithValue(ctx, hctx.TemplateOnlyRefCount, true)
                    Severity: Major
                    Found in core/controller/template/controller.go - About 35 mins to fix

                      Method controller.CreatePipelineRun has 5 return statements (exceeds 4 allowed).
                      Open

                      func (c *controller) CreatePipelineRun(ctx context.Context, clusterID uint,
                          r *CreatePipelineRunRequest) (*prmodels.PipelineBasic, error) {
                          const op = "pipelinerun controller: create pipelinerun"
                          defer wlog.Start(ctx, op).StopPrint()
                       
                       
                      Severity: Major
                      Found in core/controller/cluster/controller_basic_v2.go - About 35 mins to fix

                        Method service.listGroupMembers has 5 return statements (exceeds 4 allowed).
                        Open

                        func (s *service) listGroupMembers(ctx context.Context, resourceID uint) ([]models.Member, error) {
                            var (
                                retMembers []models.Member
                                members    []models.Member
                                err        error
                        Severity: Major
                        Found in pkg/member/service/service.go - About 35 mins to fix

                          Method controller.List has 5 return statements (exceeds 4 allowed).
                          Open

                          func (c *controller) List(ctx context.Context, applicationID uint) (ApplicationRegion, error) {
                              applicationRegions, err := c.mgr.ListByApplicationID(ctx, applicationID)
                              if err != nil {
                                  return nil, perror.WithMessage(err, "failed to list application regions")
                              }
                          Severity: Major
                          Found in core/controller/applicationregion/controller.go - About 35 mins to fix

                            Method controller.GetClusterStatusV2 has 5 return statements (exceeds 4 allowed).
                            Open

                            func (c *controller) GetClusterStatusV2(ctx context.Context, clusterID uint) (*StatusResponseV2, error) {
                                const op = "cluster controller: get cluster status v2"
                                defer wlog.Start(ctx, op).StopPrint()
                             
                                cluster, err := c.clusterMgr.GetByID(ctx, clusterID)
                            Severity: Major
                            Found in core/controller/cluster/controller_basic_v2.go - About 35 mins to fix

                              Method Params.check has 5 return statements (exceeds 4 allowed).
                              Open

                              func (params *Params) check() error {
                                  const op = "s3 params check"
                                  if len(params.AccessKey) == 0 {
                                      return errors.E(op, "AccessKey must be specified")
                                  }
                              Severity: Major
                              Found in lib/s3/s3.go - About 35 mins to fix

                                Function RenderOutputObject has 5 return statements (exceeds 4 allowed).
                                Open

                                func RenderOutputObject(outPutStr, templateName string,
                                    clusterValueFiles ...gitrepo.ClusterValueFile) (interface{}, error) {
                                    // remove the  template prefix level, add Value prefix(as helm) and merge to one doc
                                    oneMap := make(map[string]interface{})
                                    var err error
                                Severity: Major
                                Found in core/controller/cluster/controller_basic.go - About 35 mins to fix

                                  Method service.GetCheckByResource has 5 return statements (exceeds 4 allowed).
                                  Open

                                  func (s *service) GetCheckByResource(ctx context.Context, resourceID uint,
                                      resourceType string) ([]*models.Check, error) {
                                      var (
                                          id      = resourceID
                                          app     *amodels.Application
                                  Severity: Major
                                  Found in pkg/pr/service/service.go - About 35 mins to fix

                                    Method dao.DeleteByID has 5 return statements (exceeds 4 allowed).
                                    Open

                                    func (d *dao) DeleteByID(ctx context.Context, id uint) error {
                                        _, err := d.GetByID(ctx, id)
                                        if err != nil {
                                            return err
                                        }
                                    Severity: Major
                                    Found in pkg/registry/dao/dao.go - About 35 mins to fix

                                      Method WebhookLogGenerator.makeRequestBody has 5 return statements (exceeds 4 allowed).
                                      Open

                                      func (w *WebhookLogGenerator) makeRequestBody(ctx context.Context, dep *messageDependency) (string, error) {
                                          message := MessageContent{
                                              EventID:   dep.event.ID,
                                              WebhookID: dep.webhook.ID,
                                              EventType: dep.event.EventType,
                                      Severity: Major
                                      Found in pkg/eventhandler/wlgenerator/wlgenerator.go - About 35 mins to fix

                                        Method OauthManager.RefreshOauthTokens has 5 return statements (exceeds 4 allowed).
                                        Open

                                        func (m *OauthManager) RefreshOauthTokens(ctx context.Context,
                                            req *OauthTokensRequest) (*OauthTokensResponse, error) {
                                            // check client secret
                                            err := m.checkClientSecret(ctx, req)
                                            if err != nil {
                                        Severity: Major
                                        Found in pkg/oauth/manager/manager.go - About 35 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language