Sign upLogin

horizoncd/horizon

View on GitHub
Star
pkg/group/manager/manager.go

Summary

Maintainability
B
4 hrs
Test Coverage
D
63%

Showing 5 of 5 total issues

manager has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

type manager struct {
    groupDAO       groupdao.DAO
    applicationDAO applicationdao.DAO
    envregionDAO   envregiondao.DAO
    regionDAO      regiondao.DAO
Severity: Minor
Found in pkg/group/manager/manager.go - About 2 hrs to fix

    Method manager.GetDefaultRegions has 5 return statements (exceeds 4 allowed).
    Open

    func (m manager) GetDefaultRegions(ctx context.Context, id uint) ([]*envregionmodels.EnvironmentRegion, error) {
        selectableRegions, err := m.GetSelectableRegions(ctx, id)
        if err != nil {
            return nil, err
        }
    Severity: Major
    Found in pkg/group/manager/manager.go - About 35 mins to fix

      Method manager.GetSelectableRegions has 5 return statements (exceeds 4 allowed).
      Open

      func (m manager) GetSelectableRegions(ctx context.Context, id uint) (regionmodels.RegionParts, error) {
          // get regionSelector field from group
          group, err := m.groupDAO.GetByID(ctx, id)
          if err != nil {
              return nil, err
      Severity: Major
      Found in pkg/group/manager/manager.go - About 35 mins to fix

        Method manager.UpdateBasic has 5 return statements (exceeds 4 allowed).
        Open

        func (m manager) UpdateBasic(ctx context.Context, group *models.Group) error {
            if err := m.checkApplicationExists(ctx, group); err != nil {
                return err
            }
         
         
        Severity: Major
        Found in pkg/group/manager/manager.go - About 35 mins to fix

          Method manager.Delete has 5 return statements (exceeds 4 allowed).
          Open

          func (m manager) Delete(ctx context.Context, id uint) (int64, error) {
              count, err := m.groupDAO.CountByParentID(ctx, id)
              if err != nil {
                  return 0, err
              }
          Severity: Major
          Found in pkg/group/manager/manager.go - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status