Sign upLogin

horizoncd/horizon

View on GitHub
Star
pkg/jobs/k8sevent/k8sevent.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method eventHandler.mapEvent has 70 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (e *eventHandler) mapEvent(event *corev1.Event) (*eventmodels.Event, error) {
    if event == nil {
        return nil, nil
    }
    extra, err := json.Marshal(e.compactEvent(event))
Severity: Minor
Found in pkg/jobs/k8sevent/k8sevent.go - About 1 hr to fix

    Method eventHandler.save has 63 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (e *eventHandler) save(cache []*corev1.Event) error {
    select {
    case <-e.stopCh:
        return nil
    default:
    Severity: Minor
    Found in pkg/jobs/k8sevent/k8sevent.go - About 1 hr to fix

      Method eventHandler.mapEvent has 12 return statements (exceeds 4 allowed).
      Open

      func (e *eventHandler) mapEvent(event *corev1.Event) (*eventmodels.Event, error) {
    if event == nil {
        return nil, nil
    }
    extra, err := json.Marshal(e.compactEvent(event))
      Severity: Major
      Found in pkg/jobs/k8sevent/k8sevent.go - About 1 hr to fix

        Method eventHandler.mapEvent has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
        Open

        func (e *eventHandler) mapEvent(event *corev1.Event) (*eventmodels.Event, error) {
    if event == nil {
        return nil, nil
    }
    extra, err := json.Marshal(e.compactEvent(event))
        Severity: Minor
        Found in pkg/jobs/k8sevent/k8sevent.go - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method eventHandler.save has 9 return statements (exceeds 4 allowed).
        Open

        func (e *eventHandler) save(cache []*corev1.Event) error {
    select {
    case <-e.stopCh:
        return nil
    default:
        Severity: Major
        Found in pkg/jobs/k8sevent/k8sevent.go - About 55 mins to fix

          Method eventHandler.save has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
          Open

          func (e *eventHandler) save(cache []*corev1.Event) error {
    select {
    case <-e.stopCh:
        return nil
    default:
          Severity: Minor
          Found in pkg/jobs/k8sevent/k8sevent.go - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status