Sign upLogin

horizoncd/horizon

View on GitHub
Star
pkg/member/service/service.go

Summary

Maintainability
C
1 day
Test Coverage
F
57%

Method service.RequirePermissionEqualOrHigher has 7 return statements (exceeds 4 allowed).
Open

func (s *service) RequirePermissionEqualOrHigher(ctx context.Context, role,
    resourceType string, resourceID uint) error {
    currentUser, err := common.UserFromContext(ctx)
    if err != nil {
        return err
Severity: Major
Found in pkg/member/service/service.go - About 45 mins to fix

    Method service.UpdateMember has 7 return statements (exceeds 4 allowed).
    Open

    func (s *service) UpdateMember(ctx context.Context, memberID uint, role string) (*models.Member, error) {
    // 1. get the member
    memberItem, err := s.memberManager.GetByID(ctx, memberID)
    if err != nil {
        return nil, err
    Severity: Major
    Found in pkg/member/service/service.go - About 45 mins to fix

      Method service.CreateMember has 6 return statements (exceeds 4 allowed).
      Open

      func (s *service) CreateMember(ctx context.Context, postMember PostMember) (*models.Member, error) {
    var currentUser userauth.User
    currentUser, err := common.UserFromContext(ctx)
    if err != nil {
        return nil, err
      Severity: Major
      Found in pkg/member/service/service.go - About 40 mins to fix

        Method service.RemoveMember has 6 return statements (exceeds 4 allowed).
        Open

        func (s *service) RemoveMember(ctx context.Context, memberID uint) error {
    // 1. get member
    memberItem, err := s.memberManager.GetByID(ctx, memberID)
    if err != nil {
        return err
        Severity: Major
        Found in pkg/member/service/service.go - About 40 mins to fix

          Method service.getMember has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func (s *service) getMember(ctx context.Context, resourceType string, resourceID uint,
    memberType models.MemberType, memberInfo uint) (*models.Member, error) {
          Severity: Minor
          Found in pkg/member/service/service.go - About 35 mins to fix

            Method service.listGroupMembers has 5 return statements (exceeds 4 allowed).
            Open

            func (s *service) listGroupMembers(ctx context.Context, resourceID uint) ([]models.Member, error) {
    var (
        retMembers []models.Member
        members    []models.Member
        err        error
            Severity: Major
            Found in pkg/member/service/service.go - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func (s *service) listTemplateMembers(ctx context.Context, resourceID uint) ([]models.Member, error) {
    var (
        retMembers []models.Member
        members    []models.Member
        err        error
              Severity: Major
              Found in pkg/member/service/service.go and 1 other location - About 4 hrs to fix
              pkg/member/service/service.go on lines 461..493

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 310.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func (s *service) listApplicationMembers(ctx context.Context, resourceID uint) ([]models.Member, error) {
    var (
        retMembers []models.Member
        members    []models.Member
        err        error
              Severity: Major
              Found in pkg/member/service/service.go and 1 other location - About 4 hrs to fix
              pkg/member/service/service.go on lines 547..579

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 310.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status