Sign upLogin

horizoncd/horizon

View on GitHub
Star
pkg/oauth/manager/manager.go

Summary

Maintainability
B
5 hrs
Test Coverage
B
82%

Method OauthManager.GenOauthTokens has 7 return statements (exceeds 4 allowed).
Open

func (m *OauthManager) GenOauthTokens(ctx context.Context, req *OauthTokensRequest) (*OauthTokensResponse, error) {
    // check client secret
    err := m.checkClientSecret(ctx, req)
    if err != nil {
        return nil, err
Severity: Major
Found in pkg/oauth/manager/manager.go - About 45 mins to fix

    Method OauthManager.RefreshOauthTokens has 5 return statements (exceeds 4 allowed).
    Open

    func (m *OauthManager) RefreshOauthTokens(ctx context.Context,
    req *OauthTokensRequest) (*OauthTokensResponse, error) {
    // check client secret
    err := m.checkClientSecret(ctx, req)
    if err != nil {
    Severity: Major
    Found in pkg/oauth/manager/manager.go - About 35 mins to fix

      Method OauthManager.checkRefreshToken has 5 return statements (exceeds 4 allowed).
      Open

      func (m *OauthManager) checkRefreshToken(ctx context.Context,
    refreshToken, redirectURL string) (*tokenmodels.Token, error) {
    token, err := m.tokenStore.GetByCode(ctx, refreshToken)
    if err != nil {
        if _, ok := perror.Cause(err).(*herrors.HorizonErrNotFound); ok {
      Severity: Major
      Found in pkg/oauth/manager/manager.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (m *OauthManager) NewAccessToken(authorizationCodeToken *tokenmodels.Token,
    req *OauthTokensRequest) *tokenmodels.Token {
    token := &tokenmodels.Token{
        ClientID:    req.ClientID,
        RedirectURI: req.RedirectURL,
        Severity: Major
        Found in pkg/oauth/manager/manager.go and 1 other location - About 1 hr to fix
        pkg/oauth/manager/manager.go on lines 291..306

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 170.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (m *OauthManager) NewRefreshToken(accessToken *tokenmodels.Token,
    req *OauthTokensRequest) *tokenmodels.Token {
    token := &tokenmodels.Token{
        ClientID:    req.ClientID,
        RedirectURI: req.RedirectURL,
        Severity: Major
        Found in pkg/oauth/manager/manager.go and 1 other location - About 1 hr to fix
        pkg/oauth/manager/manager.go on lines 274..289

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 170.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status