Sign upLogin

horizoncd/horizon

View on GitHub
Star
pkg/regioninformers/regioninformers.go

Summary

Maintainability
B
6 hrs
Test Coverage

RegionInformers has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

type RegionInformers struct {
    regionMgr manager.Manager

    defaultResync time.Duration
Severity: Minor
Found in pkg/regioninformers/regioninformers.go - About 2 hrs to fix

    Method RegionInformers.NewRegionInformers has 51 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (f *RegionInformers) NewRegionInformers(region *models.Region) error {
    if region == nil {
        return nil
    }
    Severity: Minor
    Found in pkg/regioninformers/regioninformers.go - About 1 hr to fix

      Method RegionInformers.NewRegionInformers has 7 return statements (exceeds 4 allowed).
      Open

      func (f *RegionInformers) NewRegionInformers(region *models.Region) error {
    if region == nil {
        return nil
    }
      Severity: Major
      Found in pkg/regioninformers/regioninformers.go - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (f *RegionInformers) GetDynamicClientSet(regionID uint, operation DynamicClientSetOperation) error {
    if err := f.ensureRegion(regionID); err != nil {
        return err
    }
        Severity: Minor
        Found in pkg/regioninformers/regioninformers.go and 1 other location - About 45 mins to fix
        pkg/regioninformers/regioninformers.go on lines 299..307

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 114.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (f *RegionInformers) GetClientSet(regionID uint, operation ClientSetOperation) error {
    if err := f.ensureRegion(regionID); err != nil {
        return err
    }
        Severity: Minor
        Found in pkg/regioninformers/regioninformers.go and 1 other location - About 45 mins to fix
        pkg/regioninformers/regioninformers.go on lines 323..331

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 114.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status