Sign upLogin

horizoncd/horizon

View on GitHub
Star
pkg/util/kube/fake/fake.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method RemoteExecutor.Execute has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

func (f *RemoteExecutor) Execute(method string, url *url.URL,
    config *restclient.Config, stdin io.Reader, stdout, stderr io.Writer,
    tty bool, terminalSizeQueue remotecommand.TerminalSizeQueue) error {
Severity: Major
Found in pkg/util/kube/fake/fake.go - About 50 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func execPod1() *corev1.Pod {
    return &corev1.Pod{
        ObjectMeta: metav1.ObjectMeta{Name: "foo1", Namespace: "test", ResourceVersion: "10"},
        Spec: corev1.PodSpec{
            RestartPolicy: corev1.RestartPolicyAlways,
    Severity: Major
    Found in pkg/util/kube/fake/fake.go and 1 other location - About 1 hr to fix
    pkg/util/kube/fake/fake.go on lines 90..106

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 133.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func execPod2() *corev1.Pod {
    return &corev1.Pod{
        ObjectMeta: metav1.ObjectMeta{Name: "foo2", Namespace: "test", ResourceVersion: "10"},
        Spec: corev1.PodSpec{
            RestartPolicy: corev1.RestartPolicyAlways,
    Severity: Major
    Found in pkg/util/kube/fake/fake.go and 1 other location - About 1 hr to fix
    pkg/util/kube/fake/fake.go on lines 72..88

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 133.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status