Sign upLogin

hoschi/sweetp-service-project-context-manager

View on GitHub
Star

Showing 14 of 14 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

exports.open = {
    options: {
        params: {
            url: sweetp.PARAMETER_TYPES.url,
            config: sweetp.PARAMETER_TYPES.projectConfig,
Severity: Major
Found in src/service-methods.js and 2 other locations - About 3 hrs to fix
src/service-methods.js on lines 17..33
src/service-methods.js on lines 89..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

exports.activate = {
    options: {
        params: {
            url: sweetp.PARAMETER_TYPES.url,
            config: sweetp.PARAMETER_TYPES.projectConfig,
Severity: Major
Found in src/service-methods.js and 2 other locations - About 3 hrs to fix
src/service-methods.js on lines 71..87
src/service-methods.js on lines 89..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

exports.close = {
    options: {
        params: {
            url: sweetp.PARAMETER_TYPES.url,
            config: sweetp.PARAMETER_TYPES.projectConfig,
Severity: Major
Found in src/service-methods.js and 2 other locations - About 3 hrs to fix
src/service-methods.js on lines 17..33
src/service-methods.js on lines 71..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function exports has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (grunt) {
    // Show elapsed time at the end
    //require('time-grunt')(grunt);
    // Load all grunt tasks
    require('load-grunt-tasks')(grunt);
Severity: Major
Found in Gruntfile.js - About 2 hrs to fix

    Function callServices has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function callServices (serviceNames, db, url, project, context, callback) {
    var params, callServicesFor, serviceCalls, finalCallback;

    if (!serviceNames || serviceNames.length <= 0) {
        return callback(null);
    Severity: Major
    Found in src/callServices.js - About 2 hrs to fix

      Function activateContextWithProperties has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.activateContextWithProperties = function (params, contextProperties, callback) {
    var projectName, name, callServicesOnFinish, paramsLeet;

    projectName = params.config.name;
    name = params.name;
      Severity: Minor
      Found in src/service.js - About 1 hr to fix

        Function _openCloseContext has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports._openCloseContext = function (params, shouldBeOpen, eventHandlerPropertyName, noContextFoundMsg, callback) {
    var projectName, paramsLeet, callServicesOnFinish, contextName;

    projectName = params.config.name;
    paramsLeet = leet(params);
        Severity: Minor
        Found in src/service.js - About 1 hr to fix

          Function initDb has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          exports.initDb = function (connection, callback) {
    var db;

    db = arango.Connection(connection);
          Severity: Minor
          Found in src/dbHelper.js - About 1 hr to fix

            Function deactivateContext has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            exports.deactivateContext = function (params, callback) {
    var projectName, paramsLeet, callServicesOnFinish;

    projectName = params.config.name;
    paramsLeet = leet(params);
            Severity: Minor
            Found in src/service.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              db.document.patch(context._id, {
                    isOpen: context.isOpen
                }, dbHelper.liftDbError(function (err) {
                        next(err, context);
                    }));
              Severity: Minor
              Found in src/service.js and 1 other location - About 55 mins to fix
              src/service.js on lines 42..46

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 53.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              db.document.patch(context._id, {
                    isActive: context.isActive
                }, dbHelper.liftDbError(function (err) {
                        next(err, context);
                    }));
              Severity: Minor
              Found in src/service.js and 1 other location - About 55 mins to fix
              src/service.js on lines 206..210

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 53.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function getContexts has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              exports.getContexts = function (db, projectName, name, isActive, isOpen, callback) {
              Severity: Minor
              Found in src/dbAbstraction.js - About 45 mins to fix

                Function exports has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                module.exports = function callServices (serviceNames, db, url, project, context, callback) {
                Severity: Minor
                Found in src/callServices.js - About 45 mins to fix

                  Function _openCloseContext has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  exports._openCloseContext = function (params, shouldBeOpen, eventHandlerPropertyName, noContextFoundMsg, callback) {
                  Severity: Minor
                  Found in src/service.js - About 35 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language