Sign upLogin

houston/houston-core

View on GitHub
Star
app/channels/events_channel.rb

Summary

Maintainability
A
25 mins
Test Coverage

Assignment Branch Condition size for subscribed is too high. [17.38/15]
Open

  def subscribed
    events = [params[:event]] if params.key?(:event)
    events = params[:events] if params.key?(:events)

    events.each do |event|
Severity: Minor
Found in app/channels/events_channel.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method subscribed has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def subscribed
    events = [params[:event]] if params.key?(:event)
    events = params[:events] if params.key?(:events)

    events.each do |event|
Severity: Minor
Found in app/channels/events_channel.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Use tr instead of gsub.
Open

    "events_#{event.gsub(":", "_")}"
Severity: Minor
Found in app/channels/events_channel.rb by rubocop

This cop identifies places where gsub can be replaced by tr or delete.

Example:

# bad
'abc'.gsub('b', 'd')
'abc'.gsub('a', '')
'abc'.gsub(/a/, 'd')
'abc'.gsub!('a', 'd')

# good
'abc'.gsub(/.*/, 'a')
'abc'.gsub(/a+/, 'd')
'abc'.tr('b', 'd')
'a b c'.delete(' ')

Prefer single-quoted strings inside interpolations.
Open

    "events_#{event.gsub(":", "_")}"
Severity: Minor
Found in app/channels/events_channel.rb by rubocop

This cop checks that quotes inside the string interpolation match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
result = "Tests #{success ? "PASS" : "FAIL"}"

# good
result = "Tests #{success ? 'PASS' : 'FAIL'}"

Example: EnforcedStyle: double_quotes

# bad
result = "Tests #{success ? 'PASS' : 'FAIL'}"

# good
result = "Tests #{success ? "PASS" : "FAIL"}"

Prefer single-quoted strings inside interpolations.
Open

    "events_#{event.gsub(":", "_")}"
Severity: Minor
Found in app/channels/events_channel.rb by rubocop

This cop checks that quotes inside the string interpolation match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
result = "Tests #{success ? "PASS" : "FAIL"}"

# good
result = "Tests #{success ? 'PASS' : 'FAIL'}"

Example: EnforcedStyle: double_quotes

# bad
result = "Tests #{success ? 'PASS' : 'FAIL'}"

# good
result = "Tests #{success ? "PASS" : "FAIL"}"

Extra empty line detected at class body beginning.
Open


  def self.name_of(event)
Severity: Minor
Found in app/channels/events_channel.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Line is too long. [99/80]
Open

        Rails.logger.info "\e[31m[subscriber] \e[1m#{event}\e[0;31m is not a registered event\e[0m"
Severity: Minor
Found in app/channels/events_channel.rb by rubocop

Extra empty line detected at class body end.
Open


end
Severity: Minor
Found in app/channels/events_channel.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Line is too long. [125/80]
Open

# Be sure to restart your server when you modify this file. Action Cable runs in a loop that does not support auto reloading.
Severity: Minor
Found in app/channels/events_channel.rb by rubocop

There are no issues that match your filters.

Category
Status