hovancik/BSDSec

View on GitHub
app/helpers/application_helper.rb

Summary

Maintainability
A
0 mins
Test Coverage
F
55%
ApplicationHelper has no descriptive comment
Missing top-level documentation comment for `module ApplicationHelper`.
Missing frozen string literal comment.
module ApplicationHelper
Extra empty line detected at module body beginning.
 
ApplicationHelper#art_title doesn't depend on instance state (maybe move it to another class?)
def art_title(text)
Space missing after comma.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
text.sub("[FreeBSD-Announce]","").sub("[Midnightbsd-security]","")
end
 
ApplicationHelper#art_date doesn't depend on instance state (maybe move it to another class?)
def art_date(text)
Prefer single-quoted strings when you don't need string interpolation or special symbols.
text.strftime("%e %B, %Y")
end
 
ApplicationHelper#art_body doesn't depend on instance state (maybe move it to another class?)
def art_body(text)
ApplicationHelper#art_body has the variable name 'c'
Prefer single-quoted strings when you don't need string interpolation or special symbols.
text.lines.map { |c| c.unpack("M*") }.join.force_encoding('UTF-8')
end
 
def motif_image_url(url: root_url)
Line is too long. [304/120]
Space inside string interpolation detected.
"https://motif.imgix.com/i?url=#{u url}&image_url=#{u image_url '/img/pankaj-patel-fvMeP4ml4bU-unsplash.jpg' }&color=b1d6f4&logo_url=#{u image_url '/img/bsdsec.png' }&logo_alignment=top%2Ccenter&text_alignment=bottom%2Ccenter&logo_padding=70&font_family=Avenir%20Next%20Demi%2CBold&text_color=1d1d1d"
end
end