Sign upLogin

hoverinc/ray-tracing-renderer

View on GitHub
Star

Showing 82 of 82 total issues

Function flattenBvh has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function flattenBvh(bvh) {
  const flat = [];
  const isBounds = [];

  const splitAxisMap = {
Severity: Major
Found in src/renderer/bvhAccel.js - About 2 hrs to fix

    Function makeMaterialBuffer has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function makeMaterialBuffer(gl, materials) {
  const maps = getTexturesFromMaterials(materials, ['map', 'normalMap']);
  const pbrMap = mergeTexturesFromMaterials(materials, ['roughnessMap', 'metalnessMap']);

  const textures = {};
    Severity: Major
    Found in src/renderer/MaterialBuffer.js - About 2 hrs to fix

      Function makeUniformSetter has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function makeUniformSetter(gl, program) {
  const uniformInfo = getUniforms(gl, program);
  const uniforms = {};
  const needsUpload = [];
      Severity: Major
      Found in src/renderer/UniformSetter.js - About 2 hrs to fix

        Function makeUniformBuffer has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function makeUniformBuffer(gl, program, blockName) {
  const blockIndex = gl.getUniformBlockIndex(program, blockName);
  const blockSize = gl.getActiveUniformBlockParameter(program, blockIndex, gl.UNIFORM_BLOCK_DATA_SIZE);

  const uniforms = getUniformBlockInfo(gl, program, blockIndex);
        Severity: Major
        Found in src/renderer/UniformBuffer.js - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            const envImageTextureObject = makeTexture(gl, {
    data: envImage.data,
    storage: 'halfFloat',
    minFilter: OES_texture_float_linear ? gl.LINEAR : gl.NEAREST,
    magFilter: OES_texture_float_linear ? gl.LINEAR : gl.NEAREST,
          Severity: Major
          Found in src/renderer/RayTracePass.js and 1 other location - About 2 hrs to fix
          src/renderer/RayTracePass.js on lines 178..185

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 77.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              backgroundImageTextureObject = makeTexture(gl, {
      data: backgroundImage.data,
      storage: 'halfFloat',
      minFilter: OES_texture_float_linear ? gl.LINEAR : gl.NEAREST,
      magFilter: OES_texture_float_linear ? gl.LINEAR : gl.NEAREST,
          Severity: Major
          Found in src/renderer/RayTracePass.js and 1 other location - About 2 hrs to fix
          src/renderer/RayTracePass.js on lines 164..171

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 77.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function texturesFromMaterials has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

          function texturesFromMaterials(materials, textureName, textures) {
  const indices = [];

  for (const material of materials) {
    const isTextureLoaded = material[textureName] && material[textureName].image;
          Severity: Minor
          Found in src/renderer/texturesFromMaterials.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getTextureFormat has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function getTextureFormat(gl, channels, storage, data, gammaCorrection) {
  let type;
  let internalFormat;

  const isByteArray =
          Severity: Minor
          Found in src/renderer/Texture.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function pixelsPerFrameEstimate(gl) {
  const maxRenderbufferSize = gl.getParameter(gl.MAX_RENDERBUFFER_SIZE);

  if (maxRenderbufferSize <= 8192) {
    return 80000;
            Severity: Major
            Found in src/renderer/RenderSize.js and 1 other location - About 1 hr to fix
            src/renderer/TileRender.js on lines 109..119

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 72.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function pixelsPerTileEstimate(gl) {
  const maxRenderbufferSize = gl.getParameter(gl.MAX_RENDERBUFFER_SIZE);

  if (maxRenderbufferSize <= 8192) {
    return 200000;
            Severity: Major
            Found in src/renderer/TileRender.js and 1 other location - About 1 hr to fix
            src/renderer/RenderSize.js on lines 57..67

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 72.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function makeReprojectPass has 44 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export function makeReprojectPass(gl, params) {
  const {
    fullscreenQuad,
    maxReprojectedSamples,
  } = params;
            Severity: Minor
            Found in src/renderer/ReprojectPass.js - About 1 hr to fix

              Function makeRenderPassFromProgram has 41 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function makeRenderPassFromProgram(gl, program) {

  const uniformSetter = makeUniformSetter(gl, program);

  const textures = {};
              Severity: Minor
              Found in src/renderer/RenderPass.js - About 1 hr to fix

                Function mergeMeshesToGeometry has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                export function mergeMeshesToGeometry(meshes) {

  let vertexCount = 0;
  let indexCount = 0;
                Severity: Minor
                Found in src/renderer/mergeMeshesToGeometry.js - About 1 hr to fix

                  Function makeRenderSize has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  export function makeRenderSize(gl) {
  const desiredMsPerFrame = 20;

  let fullWidth;
  let fullHeight;
                  Severity: Minor
                  Found in src/renderer/RenderSize.js - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        const makeReprojectBuffer = () => makeFramebuffer(gl, {
        color: { 0: makeTexture(gl, { width, height, storage: 'float', magFilter: gl.LINEAR, minFilter: gl.LINEAR }) }
      });
                    Severity: Major
                    Found in src/renderer/RenderingPipeline.js and 1 other location - About 1 hr to fix
                    src/renderer/RenderingPipeline.js on lines 101..103

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 66.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        const makeHdrBuffer = () => makeFramebuffer(gl, {
      color: { 0: makeTexture(gl, { width, height, storage: 'float', magFilter: gl.LINEAR, minFilter: gl.LINEAR }) }
    });
                    Severity: Major
                    Found in src/renderer/RenderingPipeline.js and 1 other location - About 1 hr to fix
                    src/renderer/RenderingPipeline.js on lines 105..107

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 66.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function makeToneMapPass has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    export function makeToneMapPass(gl, params) {
  const {
    fullscreenQuad,
    toneMappingParams
  } = params;
                    Severity: Minor
                    Found in src/renderer/ToneMapPass.js - About 1 hr to fix

                      Function drawTile has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        function drawTile() {
    const { x, y, tileWidth, tileHeight, isFirstTile, isLastTile } = tileRender.nextTile(elapsedFrameTime);

    if (isFirstTile) {
                      Severity: Minor
                      Found in src/renderer/RenderingPipeline.js - About 1 hr to fix

                        Function decomposeScene has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        export function decomposeScene(scene) {
  const meshes = [];
  const directionalLights = [];
  const ambientLights = [];
  const environmentLights = [];
                        Severity: Minor
                        Found in src/renderer/decomposeScene.js - About 1 hr to fix

                          Function mergeMeshesToGeometry has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                          Open

                          export function mergeMeshesToGeometry(meshes) {

  let vertexCount = 0;
  let indexCount = 0;
                          Severity: Minor
                          Found in src/renderer/mergeMeshesToGeometry.js - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language