howardjones/network-weathermap

View on GitHub

Showing 380 of 1,093 total issues

Function calculateCommentPosition has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    private function calculateCommentPosition($fontObject, $comment, $direction, $widthList)
    {
        list($textWidth, $textHeight) = $fontObject->calculateImageStringSize($comment);

        // nudge pushes the comment out along the link arrow a little bit
Severity: Minor
Found in lib/Weathermap/Core/MapLink.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function readConfigLines has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function readConfigLines($inputLines)
    {
        MapUtility::debug("in readConfigLines\n");

        foreach ($inputLines as $buffer) {
Severity: Minor
Found in lib/Weathermap/Core/ConfigReader.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method init has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function init(&$link, $controlPoints, $widths, $directions = 2, $splitPosition = 50, $arrowStyle = 'classic')
Severity: Minor
Found in lib/Weathermap/Core/LinkGeometry.php - About 45 mins to fix

    Method tidySimpleDimension has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        private function tidySimpleDimension($boundingBoxA, $boundingBoxB, $nodeA, $nodeB, $simpleIndex, $simpleCoordinate)
    Severity: Minor
    Found in lib/Weathermap/Editor/Editor.php - About 45 mins to fix

      Function getBySubstring has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getBySubstring($nameFilter, $reverseOrder = false)
          {
              $result = array();
      
              foreach ($this->shapes as $shape) {
      Severity: Minor
      Found in lib/Weathermap/Core/HTMLImagemap.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method drawImageString has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function drawImageString($gdImage, $x, $y, $string, $colour, $angle = 0)
      Severity: Minor
      Found in lib/Weathermap/Core/Font.php - About 45 mins to fix

        Method drawImageString has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function drawImageString($gdImage, $x, $y, $string, $colour, $angle = 0)
        Severity: Minor
        Found in lib/Weathermap/Core/TrueTypeFont.php - About 45 mins to fix

          Function readConfigSimpleAssignment has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              private function readConfigSimpleAssignment($keyword, $matches)
              {
                  foreach ($keyword[1] as $key => $val) {
                      // so we can poke in numbers too, if the value starts with #
                      // then take the # off, and treat the rest as a number literal
          Severity: Minor
          Found in lib/Weathermap/Core/ConfigReader.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function updateMapProperties has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function updateMapProperties($params)
              {
                  if (!$this->isLoaded()) {
                      throw new WeathermapInternalFail("Map must be loaded before editing API called.");
                  }
          Severity: Minor
          Found in lib/Weathermap/Editor/Editor.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function extractSettingsCookie has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function extractSettingsCookie($cookies)
              {
                  // these are all set via the Editor Settings dialog, in the editor, now.
          
                  $this->useOverlayVIA = false; // set to TRUE to enable experimental overlay showing VIAs
          Severity: Minor
          Found in lib/Weathermap/Editor/EditorUI.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function handleNodeStep1 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function handleNodeStep1($request, $context = null)
              {
                  global $config; // Cacti config object
          
                  $hostId = -1;
          Severity: Minor
          Found in lib/Weathermap/Integrations/Cacti/EditorDataPicker.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                                  if ($size[0] > $this->minBGImageSize && $size[1] > $this->minBGImageSize) {
                                      $bg = true;
                                  }
          Severity: Major
          Found in lib/Weathermap/Editor/EditorUI.php - About 45 mins to fix

            Function mapReadOnlySettings has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function mapReadOnlySettings(
                    $id,
                    $title = ''
                ) {
                    if ($title == '') {
            Severity: Minor
            Found in lib/Weathermap/Integrations/Cacti/WeatherMapCactiManagementPlugin.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function weathermap_show_tab has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            function weathermap_show_tab()
            {
                global $config, $user_auth_realm_filenames;
                $realmID = 0;
            
            
            Severity: Minor
            Found in lib/Weathermap/Integrations/Cacti/cacti88-plugin-hooks.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method buildOverlibPositioning has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                private function buildOverlibPositioning($mapItem, $midX, $mapCenterX, $midY, $mapCenterY)
            Severity: Minor
            Found in lib/Weathermap/Core/Map.php - About 35 mins to fix

              Method drawMarkerPolygon has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public static function drawMarkerPolygon($gdImage, $colour, $point, $size, $relativeMoves)
              Severity: Minor
              Found in lib/Weathermap/Core/ImageUtility.php - About 35 mins to fix

                Method imagecreatescaledcolourizedfromfile has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function imagecreatescaledcolourizedfromfile($filename, $scaleWidth, $scaleHeight, $colour, $colourMethod)
                Severity: Minor
                Found in lib/Weathermap/Core/ImageLoader.php - About 35 mins to fix

                  Method drawLabel has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      private function drawLabel(&$map, $textPoint, $backgroundColour, $nodeImageRef, $labelBox)
                  Severity: Minor
                  Found in lib/Weathermap/Core/MapNode.php - About 35 mins to fix

                    Method addSpan has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function addSpan($lowValue, $highValue, $lowColour, $highColour = null, $tag = '')
                    Severity: Minor
                    Found in lib/Weathermap/Core/MapScale.php - About 35 mins to fix

                      Function writeImageFile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                          protected function writeImageFile($imageFileName, $imageRef)
                          {
                              $extension = strtolower(substr($imageFileName, -4, 4));
                      
                              $types = array(
                      Severity: Minor
                      Found in lib/Weathermap/Core/Map.php - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language