Sign upLogin

howardjones/network-weathermap

View on GitHub
Star
lib/Weathermap/Core/AngledLinkGeometry.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method generateOutlines has 83 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function generateOutlines()
    {
        MapUtility::debug("Calculating angled-style outline\n");

        foreach ($this->directions as $direction) {
Severity: Major
Found in lib/Weathermap/Core/AngledLinkGeometry.php - About 3 hrs to fix

    Function generateOutlines has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function generateOutlines()
    {
        MapUtility::debug("Calculating angled-style outline\n");

        foreach ($this->directions as $direction) {
    Severity: Minor
    Found in lib/Weathermap/Core/AngledLinkGeometry.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Refactor this function to reduce its Cognitive Complexity from 21 to the 15 allowed.
    Open

        protected function generateOutlines()
    Severity: Critical
    Found in lib/Weathermap/Core/AngledLinkGeometry.php by sonar-php

    Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

    See

    Remove this commented out code.
    Open

    //                $tangent = $nextTangent;
    Severity: Major
    Found in lib/Weathermap/Core/AngledLinkGeometry.php by sonar-php

    Programmers should not comment out code as it bloats programs and reduces readability.

    Unused code should be deleted and can be retrieved from source control history if required.

    See

    • MISRA C:2004, 2.4 - Sections of code should not be "commented out".
    • MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
    • MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
    • MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

    There are no issues that match your filters.

    Category
    Status