howardjones/network-weathermap

View on GitHub
lib/Weathermap/Core/Utility.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function testCronPart has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public static function testCronPart($value, $checkstring)
    {
        if ($checkstring == '*') {
            return true;
        }
Severity: Minor
Found in lib/Weathermap/Core/Utility.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return false;
Severity: Major
Found in lib/Weathermap/Core/Utility.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                        return true;
    Severity: Major
    Found in lib/Weathermap/Core/Utility.php - About 30 mins to fix

      Reduce the number of returns of this function 6, down to the maximum allowed 3.
      Open

          public static function testCronPart($value, $checkstring)
      Severity: Major
      Found in lib/Weathermap/Core/Utility.php by sonar-php

      Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.

      Noncompliant Code Example

      With the default threshold of 3:

      function myFunction(){ // Noncompliant as there are 4 return statements
        if (condition1) {
          return true;
        } else {
          if (condition2) {
            return false;
          } else {
            return true;
          }
        }
        return false;
      }
      

      Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.
      Open

          public static function testCronPart($value, $checkstring)
      Severity: Critical
      Found in lib/Weathermap/Core/Utility.php by sonar-php

      Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

      See

      Merge this if statement with the enclosing one.
      Open

                      if (($value >= intval($matches[1])) && ($value <= intval($matches[2]))) {
      Severity: Major
      Found in lib/Weathermap/Core/Utility.php by sonar-php

      Merging collapsible if statements increases the code's readability.

      Noncompliant Code Example

      if (condition1) {
        if (condition2) {
          ...
        }
      }
      

      Compliant Solution

      if (condition1 && condition2) {
        ...
      }
      

      There are no issues that match your filters.

      Category
      Status