Sign upLogin

howardjones/network-weathermap

View on GitHub
Star
lib/Weathermap/Integrations/Cacti/cacti-plugin-poller.php

Summary

Maintainability
D
1 day
Test Coverage

Function weathermap_poller_output has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

function weathermap_poller_output($rrdUpdateArray)
{
    global $config;

    $pdo = weathermap_get_pdo();
Severity: Minor
Found in lib/Weathermap/Integrations/Cacti/cacti-plugin-poller.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method weathermap_poller_output has 101 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function weathermap_poller_output($rrdUpdateArray)
{
    global $config;

    $pdo = weathermap_get_pdo();
Severity: Major
Found in lib/Weathermap/Integrations/Cacti/cacti-plugin-poller.php - About 4 hrs to fix

    Method weathermap_poller_bottom has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function weathermap_poller_bottom()
{
    global $config;
    global $weathermapPollerStartTime;
    Severity: Minor
    Found in lib/Weathermap/Integrations/Cacti/cacti-plugin-poller.php - About 1 hr to fix

      Function weathermap_poller_bottom has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      function weathermap_poller_bottom()
{
    global $config;
    global $weathermapPollerStartTime;
      Severity: Minor
      Found in lib/Weathermap/Integrations/Cacti/cacti-plugin-poller.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Refactor this function to reduce its Cognitive Complexity from 44 to the 15 allowed.
      Open

      function weathermap_poller_output($rrdUpdateArray)
      Severity: Critical
      Found in lib/Weathermap/Integrations/Cacti/cacti-plugin-poller.php by sonar-php

      Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

      See

      Remove this commented out code.
      Open

                  // db_execute("UPDATE weathermap_data SET last_time=$newtime, last_calc='$newvalue', last_value='$newlastvalue',sequence=sequence+1  where id = " . $required['id']);
      Severity: Major
      Found in lib/Weathermap/Integrations/Cacti/cacti-plugin-poller.php by sonar-php

      Programmers should not comment out code as it bloats programs and reduces readability.

      Unused code should be deleted and can be retrieved from source control history if required.

      See

      • MISRA C:2004, 2.4 - Sections of code should not be "commented out".
      • MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
      • MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
      • MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

      Define a constant instead of duplicating this literal "WEATHERMAP" 7 times.
      Open

              \cacti_log("WM poller_output: STARTING\n", true, "WEATHERMAP");
      Severity: Critical
      Found in lib/Weathermap/Integrations/Cacti/cacti-plugin-poller.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Define a constant instead of duplicating this literal "times" 9 times.
      Open

              if (isset($rrdUpdateArray[$key]['times']) && is_array($rrdUpdateArray[$key]['times'])) {
      Severity: Critical
      Found in lib/Weathermap/Integrations/Cacti/cacti-plugin-poller.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      Remove this commented out code.
      Open

      //            $poller->run();
      Severity: Major
      Found in lib/Weathermap/Integrations/Cacti/cacti-plugin-poller.php by sonar-php

      Programmers should not comment out code as it bloats programs and reduces readability.

      Unused code should be deleted and can be retrieved from source control history if required.

      See

      • MISRA C:2004, 2.4 - Sections of code should not be "commented out".
      • MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
      • MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
      • MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

      There are no issues that match your filters.

      Category
      Status