howardjones/network-weathermap

View on GitHub
lib/Weathermap/Plugins/Datasources/FPing.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method ping has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function ping(&$item, $targetAddress, $pingCount)
    {
        if (!is_executable($this->fpingCommand)) {
            MapUtility::warn("FPing ReadData: Can't find fping executable. Check path at line 36 of FPing");
            return;
Severity: Minor
Found in lib/Weathermap/Plugins/Datasources/FPing.php - About 1 hr to fix

    Function ping has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function ping(&$item, $targetAddress, $pingCount)
        {
            if (!is_executable($this->fpingCommand)) {
                MapUtility::warn("FPing ReadData: Can't find fping executable. Check path at line 36 of FPing");
                return;
    Severity: Minor
    Found in lib/Weathermap/Plugins/Datasources/FPing.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Reduce the number of returns of this function 4, down to the maximum allowed 3.
    Open

        private function ping(&$item, $targetAddress, $pingCount)

    Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.

    Noncompliant Code Example

    With the default threshold of 3:

    function myFunction(){ // Noncompliant as there are 4 return statements
      if (condition1) {
        return true;
      } else {
        if (condition2) {
          return false;
        } else {
          return true;
        }
      }
      return false;
    }
    

    There are no issues that match your filters.

    Category
    Status