Sign upLogin

howardjones/network-weathermap

View on GitHub
Star
lib/Weathermap/Plugins/Datasources/WeathermapData.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function readData has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function readData($targetString, &$map, &$mapItem)
    {
        $this->data[IN] = null;
        $this->data[OUT] = null;
Severity: Minor
Found in lib/Weathermap/Plugins/Datasources/WeathermapData.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method readData has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function readData($targetString, &$map, &$mapItem)
    {
        $this->data[IN] = null;
        $this->data[OUT] = null;
Severity: Minor
Found in lib/Weathermap/Plugins/Datasources/WeathermapData.php - About 1 hr to fix

    Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.
    Open

        public function readData($targetString, &$map, &$mapItem)
    Severity: Critical
    Found in lib/Weathermap/Plugins/Datasources/WeathermapData.php by sonar-php

    Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

    See

    There are no issues that match your filters.

    Category
    Status