howardjones/network-weathermap

View on GitHub
lib/Weathermap/Tests/ColourTest.php

Summary

Maintainability
A
0 mins
Test Coverage

Either remove this useless object instantiation of class "Colour" or use it
Open

        new Colour("scooby");

There is no good reason to create a new object to not do anything with it. Most of the time, this is due to a missing piece of code and so could lead to an unexpected behavior in production.

If it was done on purpose because the constructor has side-effects, then that side-effect code should be moved into a separate, static method and called directly.

Noncompliant Code Example

if ($x < 0) {
  new foo;  // Noncompliant
}

Compliant Solution

$var = NULL;
if ($x < 0) {
  $var = new foo;
}

There are no issues that match your filters.

Category
Status