Sign upLogin

howardjones/network-weathermap

View on GitHub
Star
lib/Weathermap/Tests/ScaleEntryTest.php

Summary

Maintainability
A
0 mins
Test Coverage

Define a constant instead of duplicating this literal "DEFAULT" 5 times.
Open

        $this->assertEquals("\tSCALE DEFAULT 0    10     0 0 0   \n", $entry1->asConfig("DEFAULT", 1000, "."));
Severity: Critical
Found in lib/Weathermap/Tests/ScaleEntryTest.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

There are no issues that match your filters.

Category
Status