Method create has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
def create
@application_letter = ApplicationLetter.new(application_params)
# event must be param to new_application_letter_path
seminar_name = ''
if params[:event_id]Method new has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def new
if !current_user
message = I18n.t('application_letters.login_before_creation')
flash[:event_id] = params[:event_id]
flash.keep(:event_id)Method new has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def new
if !current_user
message = I18n.t('application_letters.login_before_creation')
flash[:event_id] = params[:event_id]
flash.keep(:event_id)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||. Open
if @event.hidden- Read upRead up
- Exclude checks
Checks for if and unless statements that would fit on one line
if written as a modifier if/unless. The maximum line length is
configured in the Metrics/LineLength cop.
Example:
# bad
if condition
do_stuff(bar)
end
unless qux.empty?
Foo.do_something
end
# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?%i-literals should be delimited by [ and ]. Open
before_action :set_application, only: %i(show edit update destroy check)- Read upRead up
- Exclude checks
This cop enforces the consistent usage of %-literal delimiters.
Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.
Example:
# Style/PercentLiteralDelimiters:
# PreferredDelimiters:
# default: '[]'
# '%i': '()'
# good
%w[alpha beta] + %i(gamma delta)
# bad
%W(alpha #{beta})
# bad
%I(alpha beta)Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||. Open
if @event.hidden- Read upRead up
- Exclude checks
Checks for if and unless statements that would fit on one line
if written as a modifier if/unless. The maximum line length is
configured in the Metrics/LineLength cop.
Example:
# bad
if condition
do_stuff(bar)
end
unless qux.empty?
Foo.do_something
end
# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||. Open
if @event.hidden- Read upRead up
- Exclude checks
Checks for if and unless statements that would fit on one line
if written as a modifier if/unless. The maximum line length is
configured in the Metrics/LineLength cop.
Example:
# bad
if condition
do_stuff(bar)
end
unless qux.empty?
Foo.do_something
end
# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?