Sign upLogin

hpi-schuelerklub/workshop-portal

View on GitHub
Star
app/controllers/emails_controller.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method update_event has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def update_event(event)
    status = get_status
    if status == :acceptance
      event.set_status_notification_flag_for_applications_with_status(:accepted)
      event.acceptances_have_been_sent = true
Severity: Minor
Found in app/controllers/emails_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

      unless event.has_participants_without_status_notification?(:rejected) || @event.has_participants_without_status_notification?(:alternative)
Severity: Minor
Found in app/controllers/emails_controller.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

      if @event.has_participants_without_status_notification?(:alternative)
Severity: Minor
Found in app/controllers/emails_controller.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

There are no issues that match your filters.

Category
Status