Event::Ranking#get_ranking has approx 10 statements Open
def get_ranking- Read upRead up
- Exclude checks
A method with Too Many Statements is any method that has a large number of lines.
Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.
So the following method would score +6 in Reek's statement-counting algorithm:
def parse(arg, argv, &error)
if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
return nil, block, nil # +1
end
opt = (val = parse_arg(val, &error))[1] # +2
val = conv_arg(*val) # +3
if opt and !arg
argv.shift # +4
else
val[0] = nil # +5
end
val # +6
end(You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)
Complex method Event::Ranking#get_ranking (21.4) Invalid
def get_ranking
# Leaves the Array of RankingEntries empty when no teams participate in the event
@teams.each do |team|
# Considers only the team's away matches that belong to this ranking list
home_matches_in_event = team.home_matches & @matches- Read upRead up
- Exclude checks
Flog calculates the ABC score for methods. The ABC score is based on assignments, branches (method calls), and conditions.
You can read more about ABC metrics or the flog tool