hpi-swt2/workshop-portal

View on GitHub
app/helpers/applicants_overview_helper.rb

Summary

Maintainability
A
0 mins
Test Coverage

Line is too long. [88/80]
Open

    is_sorted_ascending = (params[:sort] == attr.to_s) && params[:order] != 'descending'

Missing top-level module documentation comment.
Open

module ApplicantsOverviewHelper

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Redundant use of Object#to_s in interpolation.
Open

    "<a class=\"#{'dropup' if is_sorted_ascending}\" href=\"?sort=#{attr.to_s}#{'&order=descending' if is_sorted_ascending}\">

This cop checks for string conversion in string interpolation, which is redundant.

Example:

# bad

"result is #{something.to_s}"

Example:

# good

"result is #{something}"

Line is too long. [126/80]
Open

    "<a class=\"#{'dropup' if is_sorted_ascending}\" href=\"?sort=#{attr.to_s}#{'&order=descending' if is_sorted_ascending}\">

There are no issues that match your filters.

Category
Status