hpi-swt2/workshop-portal

View on GitHub

Showing 494 of 494 total issues

Use the new Ruby 1.9 hash syntax.
Open

      pdf.text_box name, :at => [x + width / 2 - 50 , y - 20], :width => width - 100, :height => height - 100, :overflow => :shrink_to_fit

This cop checks hash literal syntax.

It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

A separate offense is registered for each problematic pair.

The supported styles are:

  • ruby19 - forces use of the 1.9 syntax (e.g. {a: 1}) when hashes have all symbols for keys
  • hash_rockets - forces use of hash rockets for all hashes
  • nomixedkeys - simply checks for hashes with mixed syntaxes
  • ruby19nomixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

Example: EnforcedStyle: ruby19 (default)

# bad
{:a => 2}
{b: 1, :c => 2}

# good
{a: 2, b: 1}
{:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
{d: 1, 'e' => 2} # technically not forbidden

Example: EnforcedStyle: hash_rockets

# bad
{a: 1, b: 2}
{c: 1, 'd' => 5}

# good
{:a => 1, :b => 2}

Example: EnforcedStyle: nomixedkeys

# bad
{:a => 1, b: 2}
{c: 1, 'd' => 2}

# good
{:a => 1, :b => 2}
{c: 1, d: 2}

Example: EnforcedStyle: ruby19nomixed_keys

# bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets

# good
{a: 1, b: 2}
{:c => 3, 'd' => 4}

Extra empty line detected at class body beginning.
Open


  # @param hide_recipients - a boolean. `true` will send an email to the recipients one by one, `false` will send an email to all at once
Severity: Minor
Found in app/services/mailer.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Line is too long. [85/80]
Open

        PortalMailer.generic_email(recipient, reply_to, subject, content).deliver_now
Severity: Minor
Found in app/services/mailer.rb by rubocop

Line is too long. [84/80]
Open

      PortalMailer.generic_email(recipients, reply_to, subject, content).deliver_now
Severity: Minor
Found in app/services/mailer.rb by rubocop

Line is too long. [84/80]
Open

  # @return [ActionMailer::MessageDelivery] a mail object with the given parameters.
Severity: Minor
Found in app/mailers/portal_mailer.rb by rubocop

Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem codeclimate-test-reporter should appear before simplecov.
Open

  gem "codeclimate-test-reporter", "~> 1.0.0"
Severity: Minor
Found in Gemfile by rubocop

Gems should be alphabetically sorted within groups.

Example:

# bad
gem 'rubocop'
gem 'rspec'

# good
gem 'rspec'
gem 'rubocop'

# good
gem 'rubocop'

gem 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
gem 'rubocop'
# For tests
gem 'rspec'

Line is too long. [124/80]
Open

# This should point at your applications config.ru, which is automatically generated by Rails when you create a new project.
Severity: Minor
Found in config/puma.rb by rubocop

Inconsistent indentation detected.
Open

    config.i18n.default_locale = :de
Severity: Minor
Found in config/application.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Missing top-level class documentation comment.
Open

  class ApplicationLetter < Rails::Application
Severity: Minor
Found in config/application.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use proc instead of Proc.new.
Open

      config.action_view.field_error_proc = Proc.new { |html_tag, instance|
Severity: Minor
Found in config/application.rb by rubocop

This cops checks for uses of Proc.new where Kernel#proc would be more appropriate.

Example:

# bad
p = Proc.new { |n| puts n }

# good
p = proc { |n| puts n }

Line is too long. [111/80]
Open

  get 'events/:id/send-acceptance-emails' => 'events#send_acceptance_emails', as: :event_send_acceptance_emails
Severity: Minor
Found in config/routes.rb by rubocop

Final newline missing.
Open

end
Severity: Minor
Found in config/initializers/errbit.rb by rubocop

Use %i or %I for an array of symbols.
Open

  before_action :set_event, only: [:show, :edit, :update, :destroy]

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  default from: "workshop.portal@gmail.com"
Severity: Minor
Found in app/mailers/application_mailer.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [105/80]
Open

  config.vm.box_url = "https://github.com/hpi-swt2/swt2-vagrant/releases/download/v0.2/swt2-trusty64.box"
Severity: Minor
Found in Vagrantfile by rubocop

Line is too long. [81/80]
Open

    @application_letters = filter_application_letters(@event.application_letters)

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    vb.customize ["modifyvm", :id, "--cpus", 2]
Severity: Minor
Found in Vagrantfile by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [113/80]
Open

# Puma forks multiple OS processes within each dyno to allow a Rails app to support multiple concurrent requests.
Severity: Minor
Found in config/puma.rb by rubocop

Line is too long. [125/80]
Open

  # @param recipients [Array<String>] - email addresses of recipients - can be a string of comma separated email adresses too
Severity: Minor
Found in app/services/mailer.rb by rubocop

Line is too long. [87/80]
Open

# This block is run after a worker is spawned, but before it begins to accept requests.
Severity: Minor
Found in config/puma.rb by rubocop
Severity
Category
Status
Source
Language