hrntsm/Tunny

File Storage.cs has 600 lines of code (exceeds 250 allowed). Consider refactoring.

Open

using System;
using System.Collections.Generic;
using System.Data.SQLite;
using System.IO;
using System.Linq;

Class SqliteStorage has 32 methods (exceeds 20 allowed). Consider refactoring.

Open

    public class SqliteStorage : IOptunaStorage
    {
        private readonly Dictionary<int, Study.Study> _studies = new Dictionary<int, Study.Study>();
        private readonly SQLiteConnectionStringBuilder _sqliteConnection;
        private int _nextStudyId;

Method CreateBaseTables has 90 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        private void CreateBaseTables()
        {
            var commands = new StringBuilder();
            commands.Append("CREATE TABLE IF NOT EXISTS alembic_version(");
            commands.Append("   version_num VARCHAR(32) PRIMARY KEY NOT NULL");

Method GetTrial has 46 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        public Trial.Trial GetTrial(int trialId)
        {
            var trial = new Trial.Trial();
            using (var connection = new SQLiteConnection(_sqliteConnection.ToString()))
            {

Method CreateNewStudy has 43 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        public int CreateNewStudy(StudyDirection[] studyDirections, string studyName)
        {
            long maxLength;
            using (var connection = new SQLiteConnection(_sqliteConnection.ToString()))
            {

Method GetAttrs has 35 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        private static void GetAttrs(Dictionary<string, object> attrs, SQLiteDataReader reader)
        {
            string key = reader.GetString(0);
            string value = reader.GetString(1);
            if (!string.IsNullOrEmpty(value) && value.Contains("[") && value.Contains("]"))

Method GetAllStudies has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        public Study.Study[] GetAllStudies()
        {
            using (var connection = new SQLiteConnection(_sqliteConnection.ToString()))
            {
                connection.Open();

Method GetStudyDirections has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        public StudyDirection[] GetStudyDirections(int studyId)
        {
            if (_studies.TryGetValue(studyId, out Study.Study value))
            {
                return value.Directions;

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        public Dictionary<string, object> GetStudyUserAttrs(int studyId)
        {
            var studyUserAttrs = new Dictionary<string, object>();
            using (var connection = new SQLiteConnection(_sqliteConnection.ToString()))
            {

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        public Dictionary<string, object> GetTrialUserAttrs(int trialId)
        {
            var trialUserAttrs = new Dictionary<string, object>();
            using (var connection = new SQLiteConnection(_sqliteConnection.ToString()))
            {

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        public Dictionary<string, object> GetStudySystemAttrs(int studyId)
        {
            var studySystemAttrs = new Dictionary<string, object>();
            using (var connection = new SQLiteConnection(_sqliteConnection.ToString()))
            {

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        public Dictionary<string, object> GetTrialSystemAttrs(int trialId)
        {
            var trialSystemAttrs = new Dictionary<string, object>();
            using (var connection = new SQLiteConnection(_sqliteConnection.ToString()))
            {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            if (directions[0] == StudyDirection.Maximize)
            {
                return allTrials.OrderByDescending(trial => trial.Values[0]).First();
            }
            else

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            {
                if (value.Contains("\""))
                {
                    value = value.Replace("\"", "");
                }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                    {
                        if (value.Contains("\""))
                        {
                            value = value.Replace("\"", "");
                        }

• Read up
  Read up