Sign upLogin

huerlisi/bookyt

View on GitHub
Star
app/models/line_item.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method price has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def price
    # If a price is set, use it
    return self[:price] unless self[:price].blank?

    # If a reference_code is given...
Severity: Minor
Found in app/models/line_item.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return 0
Severity: Major
Found in app/models/line_item.rb - About 30 mins to fix

    Method times_to_s has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def times_to_s
    if times == 1
      if quantity == "x"
        s = ""
      elsif quantity == "overall"
    Severity: Minor
    Found in app/models/line_item.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status