Sign upLogin

hugopl/reviewit

View on GitHub
Star
app/models/merge_request.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class MergeRequest has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

class MergeRequest < ApplicationRecord
  belongs_to :author, class_name: 'User'
  belongs_to :reviewer, class_name: 'User'
  belongs_to :project
Severity: Minor
Found in app/models/merge_request.rb - About 3 hrs to fix

    Method add_comments has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def add_comments(author, patch, comments, blockers)
    return if comments.nil?

    blockers ||= {}
    Severity: Minor
    Found in app/models/merge_request.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method integrate! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def integrate!(reviewer, patch_id = :not_specified)
    raise 'You tried to accept an outdated version of this merge request.' if patch.id != patch_id &&
                                                                              patch_id != :not_specified
    raise 'This merge request is already closed.' if closed?
    raise 'This merge request is being integrated by another request, please wait' if integrating?
    Severity: Minor
    Found in app/models/merge_request.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status