hugoruscitti/pilas

View on GitHub
pilasengine/actores/boton.py

Summary

Maintainability
B
5 hrs
Test Coverage

Boton has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

class Boton(Actor):
    """Representa un boton que reacciona al ser presionado.

    .. image:: ../../pilas/data/manual/imagenes/actores/boton_normal.png

Severity: Minor
Found in pilasengine/actores/boton.py - About 2 hrs to fix

    Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, pilas, x=0, y=0,
    Severity: Minor
    Found in pilasengine/actores/boton.py - About 45 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          def detection_move_mouse(self, evento):
              if self.colisiona_con_un_punto(evento.x, evento.y):
                  self.ejecutar_funciones_over()
              else:
                  self.ejecutar_funciones_normal()
      Severity: Minor
      Found in pilasengine/actores/boton.py and 1 other location - About 55 mins to fix
      pilas/actores/boton.py on lines 205..209

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def ejecutar_funciones_over(self):
              if self.estado:
                  for funcion, args, kwargs in self.funciones_over:
                      funcion(*args, **kwargs)
      Severity: Minor
      Found in pilasengine/actores/boton.py and 2 other locations - About 35 mins to fix
      pilasengine/actores/boton.py on lines 125..128
      pilasengine/actores/boton.py on lines 130..133

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def ejecutar_funciones_press(self):
              if self.estado:
                  for funcion, args, kwargs in self.funciones_press:
                      funcion(*args, **kwargs)
      Severity: Minor
      Found in pilasengine/actores/boton.py and 2 other locations - About 35 mins to fix
      pilasengine/actores/boton.py on lines 125..128
      pilasengine/actores/boton.py on lines 135..138

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          def ejecutar_funciones_normal(self):
              if self.estado:
                  for funcion, args, kwargs in self.funciones_normal:
                      funcion(*args, **kwargs)
      Severity: Minor
      Found in pilasengine/actores/boton.py and 2 other locations - About 35 mins to fix
      pilasengine/actores/boton.py on lines 130..133
      pilasengine/actores/boton.py on lines 135..138

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status