Sign upLogin

hugoruscitti/pilas

View on GitHub
Star
pilasengine/actores/mapa_tiled.py

Summary

Maintainability
D
2 days
Test Coverage

Function iniciar has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def iniciar(self, ruta_mapa=None, x=0, y=0,
Severity: Major
Found in pilasengine/actores/mapa_tiled.py - About 1 hr to fix

    Function pre_iniciar has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def pre_iniciar(self, ruta_mapa=None, x=0, y=0, densidad=0, restitucion=0,
    Severity: Major
    Found in pilasengine/actores/mapa_tiled.py - About 50 mins to fix

      Function _pintar_bloques has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def _pintar_bloques(self, capa, solidos):
        """Genera actores que representan los bloques del escenario.

        Retorna una lista de los bloques convertidos a numeros.
        """
      Severity: Minor
      Found in pilasengine/actores/mapa_tiled.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      class XmlNode:
    """Representa un nodo XML."""

    def __init__(self, domElement):
        """Construstor del nodo desde un elemento dom.
      Severity: Major
      Found in pilasengine/actores/mapa_tiled.py and 1 other location - About 1 day to fix
      pilas/actores/mapatiled.py on lines 126..153

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 160.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          def _pintar_bloques(self, capa, solidos):
        """Genera actores que representan los bloques del escenario.

        Retorna una lista de los bloques convertidos a numeros.
        """
      Severity: Major
      Found in pilasengine/actores/mapa_tiled.py and 1 other location - About 3 hrs to fix
      pilas/actores/mapatiled.py on lines 104..118

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          def _convertir_capa_en_bloques_enteros(self, capa):
        datos = capa.getChild('data').getData()
        return [[int(x) for x in x.split(',') if x] for x in datos.split()]
      Severity: Major
      Found in pilasengine/actores/mapa_tiled.py and 1 other location - About 2 hrs to fix
      pilas/actores/mapatiled.py on lines 120..122

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status