Sign upLogin

hugoruscitti/pilas

View on GitHub
Star
pilasengine/habilidades/__init__.py

Summary

Maintainability
D
3 days
Test Coverage

Habilidades has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

class Habilidades(object):
    """Representa la forma de acceso y construcción de las habilidades.

    Esta clase representa el objeto creado por pilas que
    se puede acceder escribiendo ``pilas.habilidades``. Desde aquí
Severity: Minor
Found in pilasengine/habilidades/__init__.py - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def vincular(self, clase_del_comportamiento):
        # Se asegura de que la clase sea una habilidad.
        if not issubclass(clase_del_comportamiento, Habilidad):
            mensaje = "Solo se pueden vincular clases que heredan de pilasengine.habilidades.Habilidad"
            raise Exception(mensaje)
    Severity: Major
    Found in pilasengine/habilidades/__init__.py and 1 other location - About 1 day to fix
    pilasengine/comportamientos/__init__.py on lines 82..107

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 192.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def buscar_habilidad_por_nombre(self, nombre):
        nombre = nombre.lower()

        try:
            return self.diccionario_de_habilidades[nombre]
    Severity: Major
    Found in pilasengine/habilidades/__init__.py and 1 other location - About 6 hrs to fix
    pilasengine/comportamientos/__init__.py on lines 110..123

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 99.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def _referencia_habilidad(self, modulo, clase):
        import importlib
        referencia_a_modulo = importlib.import_module('pilasengine.habilidades.'
                                                      + modulo)
        referencia_a_clase = getattr(referencia_a_modulo, clase)
    Severity: Major
    Found in pilasengine/habilidades/__init__.py and 1 other location - About 1 hr to fix
    pilasengine/comportamientos/__init__.py on lines 74..79

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            for k, v in self.diccionario_de_habilidades.items():
            self.diccionario_de_habilidades[k.lower()] = v
    Severity: Minor
    Found in pilasengine/habilidades/__init__.py and 1 other location - About 30 mins to fix
    pilasengine/comportamientos/__init__.py on lines 42..43

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status