Sign upLogin

hummingbird-me/hummingbird

View on GitHub
Star
app/controllers/pro_memberships_controller.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method create has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create
    params.permit(:token, :plan_id, :gift, :gift_to, :gift_message)

    if params[:token].blank?
      return render(text: "Didn't get credit card details from Stripe", status: 400)
Severity: Minor
Found in app/controllers/pro_memberships_controller.rb - About 1 hr to fix

    Method create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def create
    params.permit(:token, :plan_id, :gift, :gift_to, :gift_message)

    if params[:token].blank?
      return render(text: "Didn't get credit card details from Stripe", status: 400)
    Severity: Minor
    Found in app/controllers/pro_memberships_controller.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

          return render(text: "Unknown error: #{e.message}", status: 400)
    Severity: Major
    Found in app/controllers/pro_memberships_controller.rb - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status