Sign upLogin

hummingbird-me/hummingbird

View on GitHub
Star
app/models/anime.rb

Summary

Maintainability
D
1 day
Test Coverage

Method create_or_update_from_hash has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  def self.create_or_update_from_hash(hash)
    # First the creation logic
    # TODO: stop hard-coding the ID column
    anime = Anime.find_by(mal_id: hash[:external_id])
    if anime.nil? && Anime.where(title: hash[:title][:canonical]).count > 1
Severity: Minor
Found in app/models/anime.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_or_update_from_hash has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.create_or_update_from_hash(hash)
    # First the creation logic
    # TODO: stop hard-coding the ID column
    anime = Anime.find_by(mal_id: hash[:external_id])
    if anime.nil? && Anime.where(title: hash[:title][:canonical]).count > 1
Severity: Major
Found in app/models/anime.rb - About 2 hrs to fix

    File anime.rb has 258 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Anime < ActiveRecord::Base
  PG_TITLE_SCOPE = %i(title alt_title)

  AGE_RATINGS = %w(G PG13 PG R18+)
    Severity: Minor
    Found in app/models/anime.rb - About 2 hrs to fix

      Method similar has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        def similar(limit = 20, options = {})
    # FIXME
    return [] if Rails.env.development?

    exclude = options[:exclude] ? options[:exclude] : []
      Severity: Minor
      Found in app/models/anime.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method alternate_title has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def alternate_title(preference = '')
    if preference.class == User
      preference = preference.title_language_preference
    end
      Severity: Minor
      Found in app/models/anime.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method canonical_title has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def canonical_title(preference = '')
    if preference.class == User
      preference = preference.title_language_preference
    end
      Severity: Minor
      Found in app/models/anime.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

            similar_anime.push(sim) if sim &&
                                 similar_anime.length < limit &&
                                 (!self.sfw? || (self.sfw? && sim.sfw?)) &&
                                 !exclude.include?(sim)
      Severity: Major
      Found in app/models/anime.rb - About 40 mins to fix

        Avoid too many return statements within this method.
        Open

                return 'Finished Airing'
        Severity: Major
        Found in app/models/anime.rb - About 30 mins to fix

          Method status has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def status
    # If the started_airing_date is in the future or not specified,
    # the show hasn't aired yet.
    if started_airing_date.nil? || started_airing_date > Time.zone.now.to_date
      return 'Not Yet Aired'
          Severity: Minor
          Found in app/models/anime.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def alternate_title(preference = '')
    if preference.class == User
      preference = preference.title_language_preference
    end
          Severity: Minor
          Found in app/models/anime.rb and 1 other location - About 30 mins to fix
          app/models/anime.rb on lines 153..164

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def canonical_title(preference = '')
    if preference.class == User
      preference = preference.title_language_preference
    end
          Severity: Minor
          Found in app/models/anime.rb and 1 other location - About 30 mins to fix
          app/models/anime.rb on lines 170..181

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status