app/models/user.rb
Class User
has 29 methods (exceeds 20 allowed). Consider refactoring. Open
Open
class User < ActiveRecord::Base
# Friendly ID.
def to_param
name
end
File user.rb
has 297 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
class User < ActiveRecord::Base
# Friendly ID.
def to_param
name
end
Method find_for_facebook_oauth
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def self.find_for_facebook_oauth(auth, signed_in_resource=nil)
# Try to find a user already associated with the Facebook ID.
user = User.where(facebook_id: auth.uid).first
return user if user
Method find_for_facebook_oauth
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def self.find_for_facebook_oauth(auth, signed_in_resource=nil)
# Try to find a user already associated with the Facebook ID.
user = User.where(facebook_id: auth.uid).first
return user if user
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"