Sign upLogin

hummingbird-me/hummingbird

View on GitHub
Star
app/services/action.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method broadcast has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.broadcast(data)
    if data[:action_type] == "created_profile_comment"
      # Create the story and substory for this action,
      # TODO: generate notifications
      # and return the story.
Severity: Minor
Found in app/services/action.rb - About 1 hr to fix

    Method from_library_entry has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.from_library_entry(l)
    return unless l.valid?

    if l.persisted?
    Severity: Minor
    Found in app/services/action.rb - About 1 hr to fix

      Method broadcast has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.broadcast(data)
    if data[:action_type] == "created_profile_comment"
      # Create the story and substory for this action,
      # TODO: generate notifications
      # and return the story.
      Severity: Minor
      Found in app/services/action.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method from_library_entry has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.from_library_entry(l)
    return unless l.valid?

    if l.persisted?
      Severity: Minor
      Found in app/services/action.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status