Sign upLogin

hummingbird-me/kitsu-server

View on GitHub
Star
app/policies/post_like_policy.rb

Summary

Maintainability
A
2 hrs
Test Coverage
B
89%

Method create? has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def create?
    return false unless user
    return false if user.unregistered?
    return false if user&.blocked?(record.post.user)
    return false if user&.has_role?(:banned)
Severity: Minor
Found in app/policies/post_like_policy.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return false if banned_from_group?
Severity: Major
Found in app/policies/post_like_policy.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return false if group.closed? && !member?
    Severity: Major
    Found in app/policies/post_like_policy.rb - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status