Sign upLogin

hummingbird-me/kitsu-server

View on GitHub
Star

Showing 165 of 166 total issues

Method validate_each has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def validate_each(record, attr, value)
    if value.respond_to?(:each)
      value.each do |v|
        error = validate_value(v)
        record.errors.add(attr, message: error) if error
Severity: Minor
Found in app/validators/country_code_validator.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate_each has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def validate_each(record, attribute, value)
    ama = if value.respond_to?(:post)
            AMA.for_original_post(value.post).first
          elsif value.is_a?(Post)
            AMA.for_original_post(value).first
Severity: Minor
Found in app/validators/active_ama_validator.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sign_in has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def sign_in
        return @signed_in unless @signed_in.nil?

        @agent.get('https://myanimelist.net/login.php') do |login_page|
          # Already logged in!
Severity: Minor
Found in app/services/list_sync/my_anime_list/login.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  before_save do
    self.chapter_count_guess = nil if chapter_count

    if chapter_count == 1
      self.start_date = end_date if start_date.nil? && !end_date.nil?
Severity: Minor
Found in app/models/manga.rb and 1 other location - About 30 mins to fix
app/models/anime.rb on lines 90..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  before_save do
    self.episode_count_guess = nil if episode_count

    if episode_count == 1
      self.start_date = end_date if start_date.nil? && !end_date.nil?
Severity: Minor
Found in app/models/anime.rb and 1 other location - About 30 mins to fix
app/models/manga.rb on lines 50..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

      return false if banned_from_group?
Severity: Major
Found in app/policies/comment_policy.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

        return true if group && has_group_permission?(:content)
    Severity: Major
    Found in app/policies/comment_policy.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return false if banned_from_group?
      Severity: Major
      Found in app/policies/post_policy.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return :unreleased if start_date&.future?
        Severity: Major
        Found in app/models/concerns/media.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return false if user.has_role?(:banned)
          Severity: Major
          Found in app/policies/comment_like_policy.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return false if banned_from_group?
            Severity: Major
            Found in app/policies/comment_like_policy.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return false if group.closed? && !member?
              Severity: Major
              Found in app/policies/comment_like_policy.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                      return false if group.closed? && !member?
                Severity: Major
                Found in app/policies/comment_policy.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                        return false if banned_from_group?
                  Severity: Major
                  Found in app/policies/post_like_policy.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                        return true if group && has_group_permission?(:content)
                    Severity: Major
                    Found in app/policies/post_policy.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                            return false if group.closed? && !member?
                      Severity: Major
                      Found in app/policies/post_policy.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                              return false unless /[a-z]{2}(_[a-z]{2})?/ =~ title
                        Severity: Major
                        Found in app/resources/library_entry_resource.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                return false if group.closed? && !member?
                          Severity: Major
                          Found in app/policies/post_like_policy.rb - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                  return false if group.restricted? && !has_group_permission?(:content)
                            Severity: Major
                            Found in app/policies/post_policy.rb - About 30 mins to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                def self.create_defaults(count)
    episodes = ((1..count).to_a - pluck(:number)).map do |n|
      new(number: n, season_number: 1)
    end
    transaction { episodes.each(&:save) }
                              Severity: Minor
                              Found in app/models/episode.rb and 1 other location - About 25 mins to fix
                              app/models/chapter.rb on lines 16..21

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 31.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Severity
                              Category
                              Status
                              Source
                              Language