Sign upLogin

huridocs/uwazi

View on GitHub
Star
app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should convert special character string to absolute position', async () => {
    const pdfRelativePath =
      'app/api/migrations/pdf_character_count_to_absolute/specs/pdf_to_be_converted.pdf';
    const specialCharactersString = '';
Severity: Major
Found in app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts and 1 other location - About 4 hrs to fix
app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts on lines 189..214

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 163.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should match string and position when several matching strings occurs', async () => {
    const pdfRelativePath =
      'app/api/migrations/pdf_character_count_to_absolute/specs/pdf_to_be_converted.pdf';
    const severalAppearancesString = 'Continue';
Severity: Major
Found in app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts and 1 other location - About 4 hrs to fix
app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts on lines 97..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 163.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  it('should convert short label to absolute position', async () => {
    const pdfRelativePath =
      'app/api/migrations/pdf_character_count_to_absolute/specs/pdf_to_be_converted.pdf';
    const shortLabel = '26.80';
Severity: Major
Found in app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts and 3 other locations - About 3 hrs to fix
app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts on lines 22..45
app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts on lines 72..95
app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts on lines 334..357

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  it('should return first string match when range outside document', async () => {
    const pdfRelativePath =
      'app/api/migrations/pdf_character_count_to_absolute/specs/pdf_to_be_converted.pdf';
    const label = '26.80';
Severity: Major
Found in app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts and 3 other locations - About 3 hrs to fix
app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts on lines 22..45
app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts on lines 47..70
app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts on lines 72..95

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  it('should convert first label to absolute position', async () => {
    const pdfRelativePath =
      'app/api/migrations/pdf_character_count_to_absolute/specs/pdf_to_be_converted.pdf';
    const firstLabel = 'first label';
Severity: Major
Found in app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts and 3 other locations - About 3 hrs to fix
app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts on lines 47..70
app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts on lines 72..95
app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts on lines 334..357

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  it('should convert few words inside line to absolute position', async () => {
    const pdfRelativePath =
      'app/api/migrations/pdf_character_count_to_absolute/specs/pdf_to_be_converted.pdf';
    const labelInsideTag = '15  January  2019';
Severity: Major
Found in app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts and 3 other locations - About 3 hrs to fix
app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts on lines 22..45
app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts on lines 47..70
app/api/migrations/pdf_character_count_to_absolute/specs/PdfCharacterCountToAbsolute.spec.ts on lines 334..357

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status