huridocs/uwazi

View on GitHub
app/shared/specs/getIXSuggestionState.spec.ts

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    it('should mark when currentValue has value and suggestedValue, labeledValue are empty', () => {
      const values = <SuggestionValues>{
        currentValue: 'some value',
        date: 1234,
        labeledValue: '',
Severity: Major
Found in app/shared/specs/getIXSuggestionState.spec.ts and 7 other locations - About 2 hrs to fix
app/shared/specs/getIXSuggestionState.spec.ts on lines 6..27
app/shared/specs/getIXSuggestionState.spec.ts on lines 29..50
app/shared/specs/getIXSuggestionState.spec.ts on lines 98..119
app/shared/specs/getIXSuggestionState.spec.ts on lines 121..142
app/shared/specs/getIXSuggestionState.spec.ts on lines 144..165
app/shared/specs/getIXSuggestionState.spec.ts on lines 167..188
app/shared/specs/getIXSuggestionState.spec.ts on lines 190..211

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    it('should mark when currentValue != suggestedValue, labeledValue is empty', () => {
      const values = <SuggestionValues>{
        currentValue: 'some other value',
        date: 1234,
        labeledValue: '',
Severity: Major
Found in app/shared/specs/getIXSuggestionState.spec.ts and 7 other locations - About 2 hrs to fix
app/shared/specs/getIXSuggestionState.spec.ts on lines 6..27
app/shared/specs/getIXSuggestionState.spec.ts on lines 29..50
app/shared/specs/getIXSuggestionState.spec.ts on lines 52..73
app/shared/specs/getIXSuggestionState.spec.ts on lines 98..119
app/shared/specs/getIXSuggestionState.spec.ts on lines 121..142
app/shared/specs/getIXSuggestionState.spec.ts on lines 167..188
app/shared/specs/getIXSuggestionState.spec.ts on lines 190..211

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    it('should mark when currentValue != suggestedValue, labeledValue is not empty', () => {
      const values = <SuggestionValues>{
        currentValue: 'some other value',
        date: 1234,
        labeledValue: 'some other value',
Severity: Major
Found in app/shared/specs/getIXSuggestionState.spec.ts and 7 other locations - About 2 hrs to fix
app/shared/specs/getIXSuggestionState.spec.ts on lines 6..27
app/shared/specs/getIXSuggestionState.spec.ts on lines 29..50
app/shared/specs/getIXSuggestionState.spec.ts on lines 52..73
app/shared/specs/getIXSuggestionState.spec.ts on lines 98..119
app/shared/specs/getIXSuggestionState.spec.ts on lines 121..142
app/shared/specs/getIXSuggestionState.spec.ts on lines 144..165
app/shared/specs/getIXSuggestionState.spec.ts on lines 190..211

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    it('should mark when currentValue = suggestedValue, labeledValue are empty', () => {
      const values = <SuggestionValues>{
        currentValue: 'some value',
        date: 1234,
        labeledValue: '',
Severity: Major
Found in app/shared/specs/getIXSuggestionState.spec.ts and 7 other locations - About 2 hrs to fix
app/shared/specs/getIXSuggestionState.spec.ts on lines 6..27
app/shared/specs/getIXSuggestionState.spec.ts on lines 29..50
app/shared/specs/getIXSuggestionState.spec.ts on lines 52..73
app/shared/specs/getIXSuggestionState.spec.ts on lines 98..119
app/shared/specs/getIXSuggestionState.spec.ts on lines 144..165
app/shared/specs/getIXSuggestionState.spec.ts on lines 167..188
app/shared/specs/getIXSuggestionState.spec.ts on lines 190..211

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    it('should mark when suggestedValue, labeledValue and currentValue are empty', () => {
      const values = <SuggestionValues>{
        currentValue: '',
        date: 1234,
        labeledValue: '',
Severity: Major
Found in app/shared/specs/getIXSuggestionState.spec.ts and 7 other locations - About 2 hrs to fix
app/shared/specs/getIXSuggestionState.spec.ts on lines 29..50
app/shared/specs/getIXSuggestionState.spec.ts on lines 52..73
app/shared/specs/getIXSuggestionState.spec.ts on lines 98..119
app/shared/specs/getIXSuggestionState.spec.ts on lines 121..142
app/shared/specs/getIXSuggestionState.spec.ts on lines 144..165
app/shared/specs/getIXSuggestionState.spec.ts on lines 167..188
app/shared/specs/getIXSuggestionState.spec.ts on lines 190..211

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    it('should mark when currentValue = suggestedValue, labeledValue is not empty', () => {
      const values = <SuggestionValues>{
        currentValue: 'some label value',
        date: 1234,
        labeledValue: 'some label value',
Severity: Major
Found in app/shared/specs/getIXSuggestionState.spec.ts and 7 other locations - About 2 hrs to fix
app/shared/specs/getIXSuggestionState.spec.ts on lines 6..27
app/shared/specs/getIXSuggestionState.spec.ts on lines 29..50
app/shared/specs/getIXSuggestionState.spec.ts on lines 52..73
app/shared/specs/getIXSuggestionState.spec.ts on lines 121..142
app/shared/specs/getIXSuggestionState.spec.ts on lines 144..165
app/shared/specs/getIXSuggestionState.spec.ts on lines 167..188
app/shared/specs/getIXSuggestionState.spec.ts on lines 190..211

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    it('should mark when currentValue != suggestedValue, labeledValue is empty', () => {
      const values = <SuggestionValues>{
        currentValue: '',
        date: 1234,
        labeledValue: '',
Severity: Major
Found in app/shared/specs/getIXSuggestionState.spec.ts and 7 other locations - About 2 hrs to fix
app/shared/specs/getIXSuggestionState.spec.ts on lines 6..27
app/shared/specs/getIXSuggestionState.spec.ts on lines 29..50
app/shared/specs/getIXSuggestionState.spec.ts on lines 52..73
app/shared/specs/getIXSuggestionState.spec.ts on lines 98..119
app/shared/specs/getIXSuggestionState.spec.ts on lines 121..142
app/shared/specs/getIXSuggestionState.spec.ts on lines 144..165
app/shared/specs/getIXSuggestionState.spec.ts on lines 167..188

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    it('should mark when lebeledValue has value and suggestedValue is empty', () => {
      const values = <SuggestionValues>{
        currentValue: '',
        date: 1234,
        labeledValue: 'Some value',
Severity: Major
Found in app/shared/specs/getIXSuggestionState.spec.ts and 7 other locations - About 2 hrs to fix
app/shared/specs/getIXSuggestionState.spec.ts on lines 6..27
app/shared/specs/getIXSuggestionState.spec.ts on lines 52..73
app/shared/specs/getIXSuggestionState.spec.ts on lines 98..119
app/shared/specs/getIXSuggestionState.spec.ts on lines 121..142
app/shared/specs/getIXSuggestionState.spec.ts on lines 144..165
app/shared/specs/getIXSuggestionState.spec.ts on lines 167..188
app/shared/specs/getIXSuggestionState.spec.ts on lines 190..211

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status