Sign upLogin

hussar-lang/hussar

View on GitHub
Star
token/token.go

Summary

Maintainability
A
0 mins
Test Coverage

type name will be used as token.TokenType by other packages, and that stutters; consider calling this Type
Open

type TokenType string
Severity: Minor
Found in token/token.go by golint

comment on exported const FUNCTION should be of the form "FUNCTION ..."
Open

    // Keywords
Severity: Minor
Found in token/token.go by golint

comment on exported type TokenType should be of the form "TokenType ..." (with optional leading article)
Open

// Improvement: Use byte for better performance (pg12)
Severity: Minor
Found in token/token.go by golint

comment on exported const IDENT should be of the form "IDENT ..."
Open

    // Identifiers + literals
Severity: Minor
Found in token/token.go by golint

don't use ALL_CAPS in Go names; use CamelCase
Open

    NOT_EQ = "!="
Severity: Minor
Found in token/token.go by golint

exported function LookupIdent should have comment or be unexported
Open

func LookupIdent(ident string) TokenType {
Severity: Minor
Found in token/token.go by golint

comment on exported const COMMA should be of the form "COMMA ..."
Open

    // Delimitors
Severity: Minor
Found in token/token.go by golint

comment on exported const ASSIGN should be of the form "ASSIGN ..."
Open

    // Operators
Severity: Minor
Found in token/token.go by golint

comment on exported type Token should be of the form "Token ..." (with optional leading article)
Open

// Improvement: include filename, line and character place to ease debugging
Severity: Minor
Found in token/token.go by golint

exported const ILLEGAL should have comment (or a comment on this block) or be unexported
Open

    ILLEGAL = "ILLEGAL"
Severity: Minor
Found in token/token.go by golint

There are no issues that match your filters.

Category
Status