hybridgroup/artoo

View on GitHub

Showing 25 of 25 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

work do
  init_settings

  on nav, :update => :nav_update

Severity: Major
Found in examples/ardrone_nav_video_wii.rb and 1 other location - About 5 hrs to fix
examples/ardrone_nav_wiiclassic.rb on lines 14..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 180.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

work do
  init_settings

  on nav, :update => :nav_update

Severity: Major
Found in examples/ardrone_nav_wiiclassic.rb and 1 other location - About 5 hrs to fix
examples/ardrone_nav_video_wii.rb on lines 17..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 180.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method route! has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

        def route!(connection, req)
          if routes = self.class.routes[req.method]
            routes.each do |pattern, keys, conditions, block|
              route = req.url
              next unless match = pattern.match(route)
Severity: Minor
Found in lib/artoo/api/route_helpers.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Robot has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Robot
    include Celluloid
    include Celluloid::Notifications
    extend Artoo::Basic
    extend Artoo::Robot::ClassMethods
Severity: Minor
Found in lib/artoo/robot.rb - About 3 hrs to fix

    Method constantize has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        def constantize(camel_cased_word)
          names = camel_cased_word.split('::')
          names.shift if names.empty? || names.first.empty?
    
          names.inject(Object) do |constant, name|
    Severity: Minor
    Found in lib/artoo/utility.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class Master has 27 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Master
        include Celluloid
        attr_reader :robots
    
        class << self
    Severity: Minor
    Found in lib/artoo/master.rb - About 3 hrs to fix

      Method compile has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

              def compile(path)
                keys = []
                if path.respond_to? :to_str
                  ignore = ""
                  pattern = path.to_str.gsub(/[^\?\%\\\/\:\*\w]/) do |c|
      Severity: Minor
      Found in lib/artoo/api/route_helpers.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method set has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          def set(option, value = (not_set = true), ignore_setter = false, &block)
            raise ArgumentError if block and !not_set
            value, not_set = block, false if block
      
            if not_set
      Severity: Minor
      Found in lib/artoo/basic.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method connect has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

            def connect(name, port, retries = nil, baudrate = nil)
              retries |= (1 + options[:retries].to_i)
              baudrate |= options[:baudrate].to_i
      
              # check that Socat is installed
      Severity: Minor
      Found in lib/artoo/commands/socket.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method validate_params! has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

            def validate_params!
              robot = @params['robotid']
              device = @params['deviceid']
              connection = @params['connectionid']
      
      
      Severity: Minor
      Found in lib/artoo/api/api.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method dispatch! has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

              def dispatch!(connection, req)
                resp = catch(:halt) do
                  try_static! connection, req
                  route!      connection, req
                end
      Severity: Minor
      Found in lib/artoo/api/route_helpers.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method compile has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def compile(path)
                keys = []
                if path.respond_to? :to_str
                  ignore = ""
                  pattern = path.to_str.gsub(/[^\?\%\\\/\:\*\w]/) do |c|
      Severity: Minor
      Found in lib/artoo/api/route_helpers.rb - About 1 hr to fix

        Method digital_write has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

                def digital_write(value)
                  set_mode('w') unless @mode == 'w'
        
                  if value.is_a? Symbol
                    value = (value == :high) ? 1 : 0
        Severity: Minor
        Found in lib/artoo/adaptors/io/digital_pin.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method set has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def set(option, value = (not_set = true), ignore_setter = false, &block)
              raise ArgumentError if block and !not_set
              value, not_set = block, false if block
        
              if not_set
        Severity: Minor
        Found in lib/artoo/basic.rb - About 1 hr to fix

          Method force_encoding has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

                    def self.force_encoding(data, encoding = default_encoding)
                      return if data == settings || data.is_a?(Tempfile)
                      if data.respond_to? :force_encoding
                        data.force_encoding(encoding).encode!
                      elsif data.respond_to? :each_value
          Severity: Minor
          Found in lib/artoo/api/route_helpers.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method command has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def command(method_name, *arguments, &block)
                t = interface_for_command(method_name)
                if t
                  if arguments.first
                    t.send(method_name, *arguments)
          Severity: Minor
          Found in lib/artoo/robot.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            on classic, :right_joystick => proc { |*value|
              puts "right joystick x: #{value[1][:x]}, y: #{value[1][:y]}" unless (value[1][:x] == 0 && value[1][:y] == 0)
            }
            on classic, :right_trigger => proc { |*value|
          Severity: Minor
          Found in examples/wiiclassic.rb and 1 other location - About 40 mins to fix
          examples/wiiclassic.rb on lines 14..17

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 38.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            on classic, :left_joystick => proc { |*value|
              puts "left joystick x: #{value[1][:x]}, y: #{value[1][:y]}" unless (value[1][:x] == 0 && value[1][:y] == 0)
            }
            on classic, :right_joystick => proc { |*value|
          Severity: Minor
          Found in examples/wiiclassic.rb and 1 other location - About 40 mins to fix
          examples/wiiclassic.rb on lines 17..20

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 38.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              if pair[:y] > 0
                drone.up(validate_pitch(pair[:y], OFFSETS[:ry]))
              elsif pair[:y] < 0
                drone.down(validate_pitch(pair[:y], OFFSETS[:ry]))
              else
          Severity: Minor
          Found in examples/ardrone_wiiclassic.rb and 2 other locations - About 30 mins to fix
          examples/ardrone_wiiclassic.rb on lines 37..43
          examples/ardrone_wiiclassic.rb on lines 45..51

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              if pair[:y] > 0
                drone.forward(validate_pitch(pair[:y], OFFSETS[:ly]))
              elsif pair[:y] < 0
                drone.backward(validate_pitch(pair[:y], OFFSETS[:ly]))
              else
          Severity: Minor
          Found in examples/ardrone_wiiclassic.rb and 2 other locations - About 30 mins to fix
          examples/ardrone_wiiclassic.rb on lines 45..51
          examples/ardrone_wiiclassic.rb on lines 56..62

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language