Sign upLogin

hybridgroup/node-bebop

View on GitHub
Star

Showing 131 of 131 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

Bebop.prototype.up = function(val) {
  this._pcmd.gaz = validatePitch(val);
  this._pcmd.flag = 1;
  return this;
};
Severity: Major
Found in lib/bebop.js and 3 other locations - About 1 hr to fix
lib/bebop.js on lines 432..436
lib/bebop.js on lines 448..452
lib/bebop.js on lines 460..464

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

Bebop.prototype.right = function(val) {
  this._pcmd.roll = validatePitch(val);
  this._pcmd.flag = 1;
  return this;
};
Severity: Major
Found in lib/bebop.js and 3 other locations - About 1 hr to fix
lib/bebop.js on lines 416..420
lib/bebop.js on lines 432..436
lib/bebop.js on lines 460..464

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

          if (!Buffer.isBuffer(this._arstreamFrame.fragments[i])) {
            skip = true;
            break;
          }
Severity: Major
Found in lib/bebop.js - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

            else if (event.arg instanceof Object) {
          if (types.hasOwnProperty(event.arg.type)) {
            args[event.arg.name] = types[event.arg.type]
              .read(networkFrame.data, offset, event.arg);
          }
    Severity: Major
    Found in lib/bebop.js - About 45 mins to fix

      Function pcmd has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      Piloting.prototype.pcmd = function(flag, roll, pitch, yaw, gaz,
                                   timestampAndSeqNum) {
      Severity: Minor
      Found in lib/Piloting.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                        switch (networkFrame.data.readInt32LE(4)) {
                  case constants.ARCOMMANDS_ARDRONE3_PILOTINGSTATE_FLYINGSTATECHANGED_STATE_LANDED:
                    this.navData.flyingState = { landed: true };
                    this.emit("landed");
                    break;
        Severity: Major
        Found in lib/bebop.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                      if (types.hasOwnProperty(arg.type)) {
              args[arg.name] = types[arg.type]
                .read(networkFrame.data, offset, arg);

              offset += types[arg.type].length;
          Severity: Major
          Found in lib/bebop.js - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            var CommonCommands = new Promise(function (resolve, reject) {
  request('https://raw.githubusercontent.com/Parrot-Developers/libARCommands/master/Xml/common_commands.xml', function (err, res, xml) {
    resolve(parser.toJson(xml));
  })
})
            Severity: Minor
            Found in bin/updateCommands.js and 1 other location - About 40 mins to fix
            bin/updateCommands.js on lines 7..11

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            var ARDroneCommands = new Promise(function (resolve, reject) {
  request('https://raw.githubusercontent.com/Parrot-Developers/libARCommands/master/Xml/ARDrone3_commands.xml', function (err, res, xml) {
    resolve(parser.toJson(xml));
  })
})
            Severity: Minor
            Found in bin/updateCommands.js and 1 other location - About 40 mins to fix
            bin/updateCommands.js on lines 13..17

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function sendControllerGPS has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            GPSSettings.prototype.sendControllerGPS = function(latitude, longitude,
                                                   altitude, horizontalAccuracy,
                                                   verticalAccuracy) {
            Severity: Minor
            Found in lib/GPSSettings.js - About 35 mins to fix

              Function read has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  read: function(buffer, index, arg) {
      var value, name, len;
      len = buffer.length - index;
      if (len < 4) {
        name = "invalid enum";
              Severity: Minor
              Found in lib/types.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language