Sign upLogin

hypatia-software-organization/hypatia-engine

View on GitHub
Star
hypatia/animatedsprite.py

Summary

Maintainability
C
1 day
Test Coverage

File animatedsprite.py has 536 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""Quite specifically my pyganim replacement.

More advanced animation/sprite abstractions are in
the animations module.
Severity: Major
Found in hypatia/animatedsprite.py - About 1 day to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            elif type(coordinates[0]) == int and type(coordinates[1]) == int:
    Severity: Major
    Found in hypatia/animatedsprite.py and 1 other location - About 1 hr to fix
    hypatia/animatedsprite.py on lines 103..103

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            elif type(coordinates[0]) == int and type(coordinates[1]) == int:
    Severity: Major
    Found in hypatia/animatedsprite.py and 1 other location - About 1 hr to fix
    hypatia/animatedsprite.py on lines 165..165

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status