Sign upLogin

i2bskn/findable

View on GitHub
Star

Showing 15 of 15 total issues

Method update_index has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def update_index(object)
      if model.index_defined?
        indexes = model.indexes.each_with_object([]) {|name, obj|
          next if name == :id || object.public_send("#{name}_changed?")
Severity: Minor
Found in lib/findable/query.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Base has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Base
    include ActiveModel::Model
    include Associations
    include Schema
    include Inspection
Severity: Minor
Found in lib/findable/base.rb - About 2 hrs to fix

    Method find_by has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

          def find_by(conditions)
        if conditions.is_a?(Hash)
          conditions.symbolize_keys!
          if index = conditions.keys.detect {|key| key.in?(indexes) }
            value = conditions.delete(index)
    Severity: Minor
    Found in lib/findable/base.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method belongs_to has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

            def belongs_to(*args)
          name, options = Utils.parse_args(args)
          model = Utils.model_for(name, safe: true, **options)

          if model && model < Findable::Base
    Severity: Minor
    Found in lib/findable/associations/active_record_ext.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method import has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def import(hashes)
      lock do
        indexes = Hash.new {|h, k| h[k] = [] }
        values = hashes.each_with_object([]) do |hash, obj|
          hash = hash.with_indifferent_access
    Severity: Minor
    Found in lib/findable/query.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method try_lock! has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

            def try_lock!(start)
          loop do
            break if redis.setnx(@lock_key, expiration)

            current = redis.get(@lock_key).to_f
    Severity: Minor
    Found in lib/findable/query/lock.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method delete has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def delete(object)
      if model.index_defined?
        model.indexes.each do |name|
          next if name == :id
          if value = object.public_send("#{name}_was") || object.public_send(name)
    Severity: Minor
    Found in lib/findable/query.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method where has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def where(conditions)
        conditions.symbolize_keys!
        if index = conditions.keys.detect {|key| key.in?(indexes) }
          value = conditions.delete(index)
          if index == :id
    Severity: Minor
    Found in lib/findable/base.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              if model && model < Findable::Base
            foreign_key = options[:foreign_key].presence || model_name.name.foreign_key

            define_method(name) do
              model.where(foreign_key => public_send(self.class.primary_key))
    Severity: Minor
    Found in lib/findable/associations/active_record_ext.rb and 1 other location - About 35 mins to fix
    lib/findable/associations/active_record_ext.rb on lines 30..40

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              if model && model < Findable::Base
            foreign_key = options[:foreign_key].presence || model_name.name.foreign_key

            define_method(name) do
              model.find_by(foreign_key => public_send(self.class.primary_key))
    Severity: Minor
    Found in lib/findable/associations/active_record_ext.rb and 1 other location - About 35 mins to fix
    lib/findable/associations/active_record_ext.rb on lines 13..23

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method target_files has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def target_files(seed_dir: nil, seed_files: nil)
        target_dir = pathname(seed_dir || Findable.config.seed_dir)
        raise UnknownSeedDir.new(target_dir) unless target_dir.try(:exist?)

        seed_files = seed_files.map!(&:to_s) if seed_files
    Severity: Minor
    Found in lib/findable/seed.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method model_for has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def self.model_for(name, options = {})
        unless model_name = options[:class_name].presence
          name = options[:collection] ? name.to_s.singularize : name.to_s
          model_name = name.camelize
        end
    Severity: Minor
    Found in lib/findable/associations/utils.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method belongs_to has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def belongs_to(*args)
        name, options = Utils.parse_args(args)
        model = Utils.model_for(name, safe: true, **options)
        foreign_key = options[:foreign_key].presence || name.to_s.foreign_key
    Severity: Minor
    Found in lib/findable/associations.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method deserialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def deserialize(raw_data, klass = nil)
        objects = Array(raw_data).compact.map {|data|
          object = @serializer.load(data)
          object = object.with_indifferent_access if object.is_a?(Hash)
          klass ? klass.new(object) : object
    Severity: Minor
    Found in lib/findable/query/serializer.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method find has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def find(ids)
      if ids.is_a?(Array)
        if refined = records.select {|record| record.id.in?(ids) }
          regenerate(refined)
        else
    Severity: Minor
    Found in lib/findable/collection.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language